content/browser/frame_host/render_widget_host_view_guest.h - Issue 1914603002: Replace ViewHostMsg_TextInputState_Params with content::TextInputState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_guest.h

Issue 1914603002: Replace ViewHostMsg_TextInputState_Params with content::TextInputState. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_widget_host_view_child_frame.h ('K') | « content/browser/frame_host/render_widget_host_view_child_frame.cc ('k') | content/browser/frame_host/render_widget_host_view_guest.cc » ('j') | content/browser/renderer_host/render_widget_host_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_guest.h

diff --git a/content/browser/frame_host/render_widget_host_view_guest.h b/content/browser/frame_host/render_widget_host_view_guest.h

index b60aa2b3fbbd03df87f5e92ad91c63c88fa53fd7..730ee501f55c8539df9653e49e9db2b958aa2777 100644

--- a/content/browser/frame_host/render_widget_host_view_guest.h

+++ b/content/browser/frame_host/render_widget_host_view_guest.h

@@ -24,7 +24,7 @@

#include "ui/gfx/geometry/vector2d_f.h"

#include "ui/gfx/native_widget_types.h"

-struct ViewHostMsg_TextInputState_Params;

+struct TextInputState;

Charlie Reis 2016/04/22 23:02:38 nit: Move to declarations below, since this belong

EhsanK 2016/04/25 19:09:00 Done.

namespace content {

class BrowserPluginGuest;

@@ -78,8 +78,7 @@ class CONTENT_EXPORT RenderWidgetHostViewGuest

void InitAsFullscreen(RenderWidgetHostView* reference_host_view) override;

void UpdateCursor(const WebCursor& cursor) override;

void SetIsLoading(bool is_loading) override;

- void TextInputStateChanged(

- const ViewHostMsg_TextInputState_Params& params) override;

+ void TextInputStateChanged(const TextInputState& params) override;

void ImeCancelComposition() override;

#if defined(OS_MACOSX) || defined(USE_AURA)

void ImeCompositionRangeChanged(