Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1914573002: Reland of Generate Android .isolate files used for test()s (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, mikecase+watch_chromium.org, android-webview-reviews_chromium.org, jbudorick+watch_chromium.org, bengr, dgn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Generate Android .isolate files used for test()s Now uses gen.runtime rather than gen to be included by builder/tester configurations. TBR=sgurun@chromium.org,vollick@chromium.org,dpranke@chromium.org,jochen@chromium.org,agrieve@chromium.org NOTRY=true BUG=589318 Committed: https://crrev.com/5d205baf70287fec693da0166aa7aa8051b5985e Cr-Commit-Position: refs/heads/master@{#389148}

Patch Set 1 #

Patch Set 2 : gen -> gen.runtime #

Patch Set 3 : nitpick comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -13 lines) Patch
M android_webview/test/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 1 2 chunks +3 lines, -1 line 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 1 2 chunks +3 lines, -1 line 0 comments Download
M build/android/pylib/utils/isolator.py View 1 1 chunk +6 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 3 chunks +3 lines, -3 lines 0 comments Download
M cc/BUILD.gn View 1 1 chunk +5 lines, -3 lines 0 comments Download
A testing/generate_isolate.py View 1 chunk +114 lines, -0 lines 0 comments Download
M testing/test.gni View 1 2 6 chunks +105 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
agrieve
Created Reland of Generate Android .isolate files used for test()s
4 years, 8 months ago (2016-04-22 16:58:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914573002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914573002/200001
4 years, 8 months ago (2016-04-22 17:08:33 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:200001)
4 years, 8 months ago (2016-04-22 17:13:36 UTC) #8
agrieve
A revert of this CL (patchset #3 id:200001) has been created in https://codereview.chromium.org/1908253006/ by agrieve@chromium.org. ...
4 years, 8 months ago (2016-04-22 18:14:37 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:49:09 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5d205baf70287fec693da0166aa7aa8051b5985e
Cr-Commit-Position: refs/heads/master@{#389148}

Powered by Google App Engine
This is Rietveld 408576698