Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1914493002: [turbofan] Only connect the exception edge in to-number conversion. (Closed)

Created:
4 years, 8 months ago by Jarin
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Only connect the exception edge in to-number conversion. Committed: https://crrev.com/316d506297877ccedd28c837f80e3e88d4f63a5b Cr-Commit-Position: refs/heads/master@{#35738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Jarin
Could you take a look, please?
4 years, 8 months ago (2016-04-22 13:57:06 UTC) #1
Jarin
Now with a reviewer actually assigned: could you take a look, please?
4 years, 8 months ago (2016-04-22 14:07:22 UTC) #3
Benedikt Meurer
Argh, damnit. Thanks for fixing. LGTM.
4 years, 8 months ago (2016-04-22 17:51:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914493002/1
4 years, 8 months ago (2016-04-22 17:51:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 17:55:02 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/316d506297877ccedd28c837f80e3e88d4f63a5b
Cr-Commit-Position: refs/heads/master@{#35738}

Powered by Google App Engine
This is Rietveld 408576698