Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: src/compiler/js-typed-lowering.cc

Issue 1914493002: [turbofan] Only connect the exception edge in to-number conversion. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-factory.h" 5 #include "src/code-factory.h"
6 #include "src/compilation-dependencies.h" 6 #include "src/compilation-dependencies.h"
7 #include "src/compiler/access-builder.h" 7 #include "src/compiler/access-builder.h"
8 #include "src/compiler/js-graph.h" 8 #include "src/compiler/js-graph.h"
9 #include "src/compiler/js-typed-lowering.h" 9 #include "src/compiler/js-typed-lowering.h"
10 #include "src/compiler/linkage.h" 10 #include "src/compiler/linkage.h"
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 javascript()->ToNumber(), node, jsgraph()->NoContextConstant(), 228 javascript()->ToNumber(), node, jsgraph()->NoContextConstant(),
229 jsgraph()->EmptyFrameState(), graph()->start(), graph()->start()); 229 jsgraph()->EmptyFrameState(), graph()->start(), graph()->start());
230 } 230 }
231 231
232 Node* ConvertSingleInputToNumber(Node* node, Node* frame_state) { 232 Node* ConvertSingleInputToNumber(Node* node, Node* frame_state) {
233 DCHECK(!NodeProperties::GetType(node)->Is(Type::PlainPrimitive())); 233 DCHECK(!NodeProperties::GetType(node)->Is(Type::PlainPrimitive()));
234 Node* const n = graph()->NewNode(javascript()->ToNumber(), node, context(), 234 Node* const n = graph()->NewNode(javascript()->ToNumber(), node, context(),
235 frame_state, effect(), control()); 235 frame_state, effect(), control());
236 Node* const if_success = graph()->NewNode(common()->IfSuccess(), n); 236 Node* const if_success = graph()->NewNode(common()->IfSuccess(), n);
237 NodeProperties::ReplaceControlInput(node_, if_success); 237 NodeProperties::ReplaceControlInput(node_, if_success);
238 NodeProperties::ReplaceUses(node_, node_, node_, n, n); 238 NodeProperties::ReplaceUses(node_, node_, node_, node_, n);
239 update_effect(n); 239 update_effect(n);
240 return n; 240 return n;
241 } 241 }
242 242
243 void ConvertBothInputsToNumber(Node** left_result, Node** right_result, 243 void ConvertBothInputsToNumber(Node** left_result, Node** right_result,
244 Node* frame_state) { 244 Node* frame_state) {
245 Node* projections[2]; 245 Node* projections[2];
246 246
247 // Find {IfSuccess} and {IfException} continuations of the operation. 247 // Find {IfSuccess} and {IfException} continuations of the operation.
248 NodeProperties::CollectControlProjections(node_, projections, 2); 248 NodeProperties::CollectControlProjections(node_, projections, 2);
(...skipping 1580 matching lines...) Expand 10 before | Expand all | Expand 10 after
1829 } 1829 }
1830 1830
1831 1831
1832 CompilationDependencies* JSTypedLowering::dependencies() const { 1832 CompilationDependencies* JSTypedLowering::dependencies() const {
1833 return dependencies_; 1833 return dependencies_;
1834 } 1834 }
1835 1835
1836 } // namespace compiler 1836 } // namespace compiler
1837 } // namespace internal 1837 } // namespace internal
1838 } // namespace v8 1838 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698