[es8] Report proper syntax error for tail call expressions in for-in and for-of bodies.

[es8] Report proper syntax error for tail call expressions in for-in and for-of bodies.

BUG=v8:4915
LOG=Y

Committed: https://crrev.com/f95e130b7e7e4b955bb001883e1dd2db22c9f5d1
Cr-Commit-Position: refs/heads/master@{#35822}

[Igor Sheludko, 2016-04-27 10:31:34]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 10:31:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914423002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914423002/1

[Igor Sheludko, 2016-04-27 10:31:48]

ishell@chromium.org changed reviewers:
+ rossberg@chromium.org

[Igor Sheludko, 2016-04-27 10:31:49]

PTAL

[commit-bot: I haz the power, 2016-04-27 11:01:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 11:01:41]

Dry run: This issue passed the CQ dry run.

[rossberg, 2016-04-27 11:12:01]

lgtm

https://codereview.chromium.org/1914423002/diff/1/src/parsing/preparser.cc
File src/parsing/preparser.cc (right):

https://codereview.chromium.org/1914423002/diff/1/src/parsing/preparser.cc#ne...
src/parsing/preparser.cc:701: return_expr_context ==
ReturnExprContext::kInsideTryBlock
Use a switch here, to be robust against extensions of the enum.

[Igor Sheludko, 2016-04-27 11:39:48]

https://codereview.chromium.org/1914423002/diff/1/src/parsing/preparser.cc
File src/parsing/preparser.cc (right):

https://codereview.chromium.org/1914423002/diff/1/src/parsing/preparser.cc#ne...
src/parsing/preparser.cc:701: return_expr_context ==
ReturnExprContext::kInsideTryBlock
On 2016/04/27 11:12:01, rossberg wrote:
> Use a switch here, to be robust against extensions of the enum.

I moved this code to ReportIllegalTailCallAt() to the base class.

[Igor Sheludko, 2016-04-27 11:39:54]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 11:40:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914423002/20001

[commit-bot: I haz the power, 2016-04-27 12:03:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 12:03:21]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-04-27 13:00:33]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-04-27 13:00:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1914423002/#ps20001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-04-27 13:00:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914423002/20001

[commit-bot: I haz the power, 2016-04-27 13:02:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-27 13:03:19]

Description was changed from

==========
[es8] Report proper syntax error for tail call expressions in for-in and for-of
bodies.

BUG=v8:4915
LOG=Y
==========

to

==========
[es8] Report proper syntax error for tail call expressions in for-in and for-of
bodies.

BUG=v8:4915
LOG=Y

Committed: https://crrev.com/f95e130b7e7e4b955bb001883e1dd2db22c9f5d1
Cr-Commit-Position: refs/heads/master@{#35822}
==========

[commit-bot: I haz the power, 2016-04-27 13:03:20]

Patchset 2 (id:??) landed as
https://crrev.com/f95e130b7e7e4b955bb001883e1dd2db22c9f5d1
Cr-Commit-Position: refs/heads/master@{#35822}