Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1914393002: [es6] Don't eliminate tail calls from for-in and for-of bodies. (Closed)

Created:
4 years, 7 months ago by Igor Sheludko
Modified:
4 years, 7 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Don't eliminate tail calls from for-in and for-of bodies. BUG=v8:4698 LOG=N Committed: https://crrev.com/813f2778f31e5f4cb07bc5c963e24bd3387c677e Cr-Commit-Position: refs/heads/master@{#35813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M src/parsing/parser.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/tail-call.js View 1 chunk +46 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1914423002 Patch 1
Issue 1914423002 Patch 20001

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914393002/1
4 years, 7 months ago (2016-04-27 09:02:36 UTC) #2
Igor Sheludko
PTAL
4 years, 7 months ago (2016-04-27 09:02:46 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 09:24:26 UTC) #6
rossberg
Sigh. Another reason why iterator finalisation is a stupid idea. LGTM
4 years, 7 months ago (2016-04-27 09:28:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914393002/1
4 years, 7 months ago (2016-04-27 09:29:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 09:32:43 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 09:34:18 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/813f2778f31e5f4cb07bc5c963e24bd3387c677e
Cr-Commit-Position: refs/heads/master@{#35813}

Powered by Google App Engine
This is Rietveld 408576698