Implement CustomElement::isValidName()

Implement CustomElement::isValidName()

This patch implements CustomElement::IsValidName().

A valid custom element name is PotentialCustomElementName except all
hyphen-containing element names from the applicable specifications,
according to the spec below:
https://html.spec.whatwg.org/multipage/scripting.html#valid-custom-element-name

BUG=594918
Committed: https://crrev.com/53c4c0ac74bf3fbe6d1fcda1ee798b5d3817e1f3
Cr-Commit-Position: refs/heads/master@{#390308}

[kojii, 2016-04-27 05:09:24]

Description was changed from

==========
IsValidName

BUG=594918
==========

to

==========
Implement CustomElement::IsValidName()

This patch implements CustomElement::IsValidName().

A valid custom element name is PotentialCustomElementName except all
hyphen-containing element names from the applicable specifications,
according to the spec below:
https://html.spec.whatwg.org/multipage/scripting.html#valid-custom-element-name

BUG=594918
==========

[kojii, 2016-04-27 05:11:11]

kojii@chromium.org changed reviewers:
+ dominicc@chromium.org, hayato@chromium.org

[kojii, 2016-04-27 05:11:12]

PTAL.

[dominicc (has gone to gerrit), 2016-04-27 05:34:23]

https://codereview.chromium.org/1914383002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/custom/CustomElement.h (right):

https://codereview.chromium.org/1914383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/custom/CustomElement.h:17: static bool
isValidName(const AtomicString& name);
Nit: Make the symbol in the title and description match this, ie isValidName not
IsValidName.

https://codereview.chromium.org/1914383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/custom/CustomElement.h:18: static bool
isPotentialCustomElementName(const AtomicString& name);
You want to at *least* make this private, or even just roll it into isValidName.
Having two hanging around is confusing; when would you call
isPotentialCustomElementName but not want isValidName?

[kojii, 2016-04-27 06:37:29]

Description was changed from

==========
Implement CustomElement::IsValidName()

This patch implements CustomElement::IsValidName().

A valid custom element name is PotentialCustomElementName except all
hyphen-containing element names from the applicable specifications,
according to the spec below:
https://html.spec.whatwg.org/multipage/scripting.html#valid-custom-element-name

BUG=594918
==========

to

==========
Implement CustomElement::isValidName()

This patch implements CustomElement::IsValidName().

A valid custom element name is PotentialCustomElementName except all
hyphen-containing element names from the applicable specifications,
according to the spec below:
https://html.spec.whatwg.org/multipage/scripting.html#valid-custom-element-name

BUG=594918
==========

[kojii, 2016-04-27 06:55:43]

https://codereview.chromium.org/1914383002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/custom/CustomElement.h (right):

https://codereview.chromium.org/1914383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/custom/CustomElement.h:17: static bool
isValidName(const AtomicString& name);
On 2016/04/27 at 05:34:23, dominicc wrote:
> Nit: Make the symbol in the title and description match this, ie isValidName
not IsValidName.

Done, thanks.

https://codereview.chromium.org/1914383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/custom/CustomElement.h:18: static bool
isPotentialCustomElementName(const AtomicString& name);
On 2016/04/27 at 05:34:23, dominicc wrote:
> You want to at *least* make this private, or even just roll it into
isValidName. Having two hanging around is confusing; when would you call
isPotentialCustomElementName but not want isValidName?

Merged them. Confirmed that there are no other references to
PotentialCustomElementName in the spec.

[dominicc (has gone to gerrit), 2016-04-28 05:37:17]

The CQ bit was checked by dominicc@chromium.org

[dominicc (has gone to gerrit), 2016-04-28 05:37:18]

lgtm

[commit-bot: I haz the power, 2016-04-28 05:37:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914383002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914383002/40001

[commit-bot: I haz the power, 2016-04-28 05:41:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:16:24]

Patchset 3 (id:??) landed as
https://crrev.com/53c4c0ac74bf3fbe6d1fcda1ee798b5d3817e1f3
Cr-Commit-Position: refs/heads/master@{#390308}

[commit-bot: I haz the power, 2016-04-30 17:54:20]

Description was changed from

==========
Implement CustomElement::isValidName()

This patch implements CustomElement::IsValidName().

A valid custom element name is PotentialCustomElementName except all
hyphen-containing element names from the applicable specifications,
according to the spec below:
https://html.spec.whatwg.org/multipage/scripting.html#valid-custom-element-name

BUG=594918
==========

to

==========
Implement CustomElement::isValidName()

This patch implements CustomElement::IsValidName().

A valid custom element name is PotentialCustomElementName except all
hyphen-containing element names from the applicable specifications,
according to the spec below:
https://html.spec.whatwg.org/multipage/scripting.html#valid-custom-element-name

BUG=594918

Committed: https://crrev.com/53c4c0ac74bf3fbe6d1fcda1ee798b5d3817e1f3
Cr-Commit-Position: refs/heads/master@{#390308}
==========