Implement CustomElement::isValidName()

third_party/WebKit/Source/core/dom/custom/CustomElement.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CustomElement_h
 #define CustomElement_h
 
 #include "core/CoreExport.h"
 #include "wtf/Allocator.h"
 #include "wtf/text/AtomicString.h"
 
 namespace blink {
 
 class CORE_EXPORT CustomElement {
     STATIC_ONLY(CustomElement);
 public:
+    static bool isValidName(const AtomicString& name);

[dominicc (has gone to gerrit), 2016/04/27 05:34:23]

Nit: Make the symbol in the title and description match this, ie isValidName not
IsValidName.

[kojii, 2016/04/27 06:55:43]

Done, thanks.

     static bool isPotentialCustomElementName(const AtomicString& name);

[dominicc (has gone to gerrit), 2016/04/27 05:34:23]

You want to at *least* make this private, or even just roll it into isValidName.
Having two hanging around is confusing; when would you call
isPotentialCustomElementName but not want isValidName?

[kojii, 2016/04/27 06:55:43]

Merged them. Confirmed that there are no other references to
PotentialCustomElementName in the spec.

 };
 
 } // namespace blink
 
 #endif // CustomElement_h