Chromium Code Reviews| Index: components/offline_pages/background/BUILD.gn |
| diff --git a/components/offline_pages/background/BUILD.gn b/components/offline_pages/background/BUILD.gn |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..96448fd4068ecc6ed8b0ce88d550d9bb81e75f55 |
| --- /dev/null |
| +++ b/components/offline_pages/background/BUILD.gn |
| @@ -0,0 +1,22 @@ |
| +# Copyright 2016 The Chromium Authors. All rights reserved. |
| +# Use of this source code is governed by a BSD-style license that can be |
| +# found in the LICENSE file. |
| + |
| +if (is_android) { |
| + import("//build/config/android/rules.gni") |
| +} |
| + |
| +# GYP: //components/offline_pages/offline_pages.gypi:background_offlining |
|
fgorski
2016/04/28 11:54:59
a) gyp says background_offliner
b) I see value in
Pete Williamson
2016/04/28 20:22:03
Changed to background_offliner to be consistent.
W
|
| +static_library("background_offlining") { |
| + sources = [ |
| + "request_coordinator.cc", |
|
jochen (gone - plz use gerrit)
2016/04/28 15:39:06
why are the sources of the gyp and gn target diffe
Pete Williamson
2016/04/28 20:22:03
Looking elsewhere, it seems that the .gypi files m
Pete Williamson
2016/04/28 22:14:32
After asking around, it looks like I picked a bad
|
| + ] |
| + |
| + deps = [ |
| + "//base", |
| + "//components/bookmarks/browser", |
|
fgorski
2016/04/28 11:54:58
not needed I think
Pete Williamson
2016/04/28 20:22:03
Done.
|
| + "//components/offline_pages:offline_pages", |
| + "//net", |
| + "//url", |
| + ] |
| +} |