Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: components/offline_pages/background/BUILD.gn

Issue 1914333002: Adding a BUILD file for both gyp and gn for the new background_offlining (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR changes per DougArnett Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 if (is_android) {
6 import("//build/config/android/rules.gni")
7 }
8
9 # GYP: //components/offline_pages/offline_pages.gypi:background_offlining
fgorski 2016/04/28 11:54:59 a) gyp says background_offliner b) I see value in
Pete Williamson 2016/04/28 20:22:03 Changed to background_offliner to be consistent. W
10 static_library("background_offlining") {
11 sources = [
12 "request_coordinator.cc",
jochen (gone - plz use gerrit) 2016/04/28 15:39:06 why are the sources of the gyp and gn target diffe
Pete Williamson 2016/04/28 20:22:03 Looking elsewhere, it seems that the .gypi files m
Pete Williamson 2016/04/28 22:14:32 After asking around, it looks like I picked a bad
13 ]
14
15 deps = [
16 "//base",
17 "//components/bookmarks/browser",
fgorski 2016/04/28 11:54:58 not needed I think
Pete Williamson 2016/04/28 20:22:03 Done.
18 "//components/offline_pages:offline_pages",
19 "//net",
20 "//url",
21 ]
22 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698