Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1914243002: Add some code to ensure that stdout is always flushed and closed to help debug layout tests hanging… (Closed)

Created:
4 years, 8 months ago by jam
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add some code to ensure that stdout is always flushed and closed to help debug layout tests hanging on Windows trybots. BUG=522396 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M scripts/slave/chromium/layout_test_wrapper.py View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
jam
I'll try this for a day and then revert if it still occurs.
4 years, 8 months ago (2016-04-26 17:59:34 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914243002/1
4 years, 8 months ago (2016-04-26 18:08:14 UTC) #4
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
4 years, 8 months ago (2016-04-26 18:08:20 UTC) #6
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-26 18:16:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914243002/1
4 years, 8 months ago (2016-04-26 18:16:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build Try Recipe Test Trusty64 on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Try%20Recipe%20Test%20Trusty64/builds/1212)
4 years, 8 months ago (2016-04-26 18:25:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914243002/1
4 years, 8 months ago (2016-04-26 19:24:57 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300202
4 years, 8 months ago (2016-04-26 19:28:33 UTC) #15
jam
4 years, 8 months ago (2016-04-26 21:49:37 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1919403003/ by jam@chromium.org.

The reason for reverting is: hang still occurred:
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel....

Powered by Google App Engine
This is Rietveld 408576698