Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: scripts/slave/chromium/layout_test_wrapper.py

Issue 1914243002: Add some code to ensure that stdout is always flushed and closed to help debug layout tests hanging… (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/chromium/layout_test_wrapper.py
diff --git a/scripts/slave/chromium/layout_test_wrapper.py b/scripts/slave/chromium/layout_test_wrapper.py
index 886525439acbbe90b23ec2351cc4872322e6aa6f..2cb9782af54d327e2c3eb722f73d2fc590fb27a6 100755
--- a/scripts/slave/chromium/layout_test_wrapper.py
+++ b/scripts/slave/chromium/layout_test_wrapper.py
@@ -150,6 +150,13 @@ def layout_test(options, args):
return slave_utils.RunPythonCommandInBuildDir(build_dir, options.target,
command)
finally:
+ if 'win_chromium_rel_ng' in sys.argv:
+ print 'layout_test_wrapper calling stdout.flush()'
+ try:
+ sys.stdout.flush()
+ finally:
+ print 'layout_test_wrapper calling stdout.close()'
+ sys.stdout.close()
if options.enable_pageheap:
slave_utils.SetPageHeap(build_dir, dumprendertree_exe, False)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698