tools/perf/measurements/v8_gc_times.py - Issue 1914233003: [tools/perf] Delete unused variable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/v8_gc_times.py

Issue 1914233003: [tools/perf] Delete unused variable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/v8_gc_times.py

diff --git a/tools/perf/measurements/v8_gc_times.py b/tools/perf/measurements/v8_gc_times.py

index 7c323c37e80b8e10156f27eba5b1b1fcd7d4a939..e1d5d13b54c03747a27be8ad195a96dcbe65a4f7 100644

--- a/tools/perf/measurements/v8_gc_times.py

+++ b/tools/perf/measurements/v8_gc_times.py

@@ -23,6 +23,7 @@ class V8GCTimes(page_test.PageTest):

super(V8GCTimes, self).__init__()

def WillNavigateToPage(self, page, tab):

+ del page # unused

config = tracing_config.TracingConfig()

for category in self._CATEGORIES:

config.tracing_category_filter.AddIncludedCategory(category)

@@ -31,6 +32,7 @@ class V8GCTimes(page_test.PageTest):

config, self._TIME_OUT_IN_SECONDS)

def ValidateAndMeasurePage(self, page, tab, results):

+ del page # unused

trace_data = tab.browser.platform.tracing_controller.StopTracing()

timeline_model = TimelineModel(trace_data)

renderer_process = timeline_model.GetRendererProcessFromTabId(tab.id)