tools/perf/measurements/v8_detached_context_age_in_gc.py - Issue 1914233003: [tools/perf] Delete unused variable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/v8_detached_context_age_in_gc.py

Issue 1914233003: [tools/perf] Delete unused variable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/v8_detached_context_age_in_gc.py

diff --git a/tools/perf/measurements/v8_detached_context_age_in_gc.py b/tools/perf/measurements/v8_detached_context_age_in_gc.py

index 1c10c11b8092edbf78f30749549caf4c5fa87a02..ffb3fb4e7cd1c825210378f25f4cc5b73d826109 100644

--- a/tools/perf/measurements/v8_detached_context_age_in_gc.py

+++ b/tools/perf/measurements/v8_detached_context_age_in_gc.py

@@ -36,9 +36,11 @@ class V8DetachedContextAgeInGC(page_test.PageTest):

options.AppendExtraBrowserArgs(['--enable-stats-collection-bindings'])

def DidNavigateToPage(self, page, tab):

+ del page # unused

self._data_start = histogram_util.GetHistogram(_TYPE, _NAME, tab)

def ValidateAndMeasurePage(self, page, tab, results):

+ del page # unused

# Trigger GC to get histogram data.

# Seven GCs should be enough to collect any detached context.

# If a detached context survives more GCs then there is a leak.

« no previous file with comments | « tools/perf/measurements/thread_times.py ('k') | tools/perf/measurements/v8_gc_times.py » ('j') | no next file with comments »