Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2407)

Unified Diff: appengine/findit/crash/test/callstack_test.py

Issue 1914113002: [Findit] Enable project classifier and component classifier (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Address comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/callstack_test.py
diff --git a/appengine/findit/crash/test/callstack_test.py b/appengine/findit/crash/test/callstack_test.py
index e6e5bd262bec9c9d08818ed13d2715df1655726e..5640a68b40738a73898606f44f4fd2c7b2d40f6b 100644
--- a/appengine/findit/crash/test/callstack_test.py
+++ b/appengine/findit/crash/test/callstack_test.py
@@ -12,14 +12,14 @@ class CallStackTest(StacktraceTestSuite):
def testStackFrameToString(self):
self.assertEqual(
- StackFrame(0, 'src/', '', 'func', 'f.cc', []).ToString(),
+ StackFrame(0, 'src/', 'func', 'f.cc', 'src/f.cc', []).ToString(),
'#0 in func @ f.cc')
self.assertEqual(
- StackFrame(0, 'src/', '', 'func', 'f.cc', [1]).ToString(),
+ StackFrame(0, 'src/', 'func', 'f.cc', 'src/f.cc', [1]).ToString(),
'#0 in func @ f.cc:1')
self.assertEqual(
- StackFrame(0, 'src/', '', 'func', 'f.cc', [1, 2, 3, 4]).ToString(),
- '#0 in func @ f.cc:1:3')
+ StackFrame(0, 'src/', 'func', 'f.cc', 'src/f.cc', [1, 2]).ToString(),
+ '#0 in func @ f.cc:1:1')
def testParseLineForJavaCallstackFormat(self):
stack = CallStack(0, CallStackFormatType.JAVA)
@@ -31,7 +31,7 @@ class CallStackTest(StacktraceTestSuite):
stack.ParseLine(' at org.a.b(a.java:609)', deps)
self._VerifyTwoStackFramesEqual(
stack[0],
- StackFrame(0, 'org/', '', 'org.a.b', 'a.java', [609]))
+ StackFrame(0, 'org/', 'org.a.b', 'a.java', 'org/a.java', [609]))
def testParseLineForSyzyasanCallstackFormat(self):
stack = CallStack(0, CallStackFormatType.SYZYASAN)
@@ -43,7 +43,8 @@ class CallStackTest(StacktraceTestSuite):
stack.ParseLine('c::p::n [src/content/e.cc @ 165]', deps)
self._VerifyTwoStackFramesEqual(
stack[0],
- StackFrame(0, 'src/content/', '', 'c::p::n', 'e.cc', [165]))
+ StackFrame(
+ 0, 'src/content/', 'c::p::n', 'e.cc', 'src/content/e.cc', [165]))
def testParseLineForDefaultCallstackFormat(self):
stack = CallStack(0, CallStackFormatType.DEFAULT)
@@ -58,4 +59,5 @@ class CallStackTest(StacktraceTestSuite):
stack.ParseLine('#0 0x52617a in func0 tp/webrtc/a.c:38:3', deps)
self._VerifyTwoStackFramesEqual(
stack[0],
- StackFrame(0, 'tp/webrtc/', '', 'func0', 'a.c', [38, 39, 40, 41]))
+ StackFrame(
+ 0, 'tp/webrtc/', 'func0', 'a.c', 'tp/webrtc/a.c', [38, 39, 40, 41]))

Powered by Google App Engine
This is Rietveld 408576698