appengine/findit/crash/test/callstack_filters_test.py - Issue 1914113002: [Findit] Enable project classifier and component classifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/crash/test/callstack_filters_test.py

Issue 1914113002: [Findit] Enable project classifier and component classifier (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Address comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/findit/crash/project_classifier.py ('K') | « appengine/findit/crash/scorers/test/aggregator_test.py ('k') | appengine/findit/crash/test/callstack_test.py » ('j') | appengine/findit/model/crash/crash_config.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/crash/test/callstack_filters_test.py

diff --git a/appengine/findit/crash/test/callstack_filters_test.py b/appengine/findit/crash/test/callstack_filters_test.py

index 2231acfeedcafcdb06558b1ac7e3da59e18aea9b..4e4ddfdf5128137b68fc9c103dfb2f1d54ef5aa5 100644

--- a/appengine/findit/crash/test/callstack_filters_test.py

+++ b/appengine/findit/crash/test/callstack_filters_test.py

@@ -21,9 +21,9 @@ class CallStackFiltersTest(StacktraceTestSuite):

def testFilterFramesBeforeSignature(self):

callstack = CallStack(0)

callstack.extend(

- [StackFrame(0, 'src/', '', 'func', 'file0.cc', [32]),

- StackFrame(0, 'src/', '', 'signature_func', 'file1.cc', [53]),

- StackFrame(0, 'src/', '', 'funcc', 'file2.cc', [3])])

+ [StackFrame(0, 'src/', 'func', 'f0.cc', 'src/f0.cc', [32]),

+ StackFrame(0, 'src/', 'signature_func', 'f1.cc', 'src/f1.cc', [53]),

+ StackFrame(0, 'src/', 'funcc', 'f2.cc', 'src/f2.cc', [3])])

filtered_callstack = copy.copy(callstack)

callstack_filters.FilterFramesBeforeSignature(

@@ -31,7 +31,7 @@ class CallStackFiltersTest(StacktraceTestSuite):

expected_callstack = CallStack(0)

expected_callstack.extend(

- [StackFrame(0, 'src/', '', 'signature_func', 'file1.cc', [53]),

- StackFrame(0, 'src/', '', 'funcc', 'file2.cc', [3])])

+ [StackFrame(0, 'src/', 'signature_func', 'f1.cc', 'src/f1.cc', [53]),

+ StackFrame(0, 'src/', 'funcc', 'f2.cc', 'src/f2.cc', [3])])

self._VerifyTwoCallStacksEqual(filtered_callstack, expected_callstack)