Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Unified Diff: chrome/browser/resources/options/search_engine_manager_engine_list.js

Issue 1914073005: Make getFaviconImageSet work with all expected URL types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: case insensitive Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/util_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/search_engine_manager_engine_list.js
diff --git a/chrome/browser/resources/options/search_engine_manager_engine_list.js b/chrome/browser/resources/options/search_engine_manager_engine_list.js
index 024e62f8d09918e3a3dac33ade7aa40a2df0acf9..3c9b238feaea5fff21fa98aca8cc7a7b02269797 100644
--- a/chrome/browser/resources/options/search_engine_manager_engine_list.js
+++ b/chrome/browser/resources/options/search_engine_manager_engine_list.js
@@ -122,10 +122,9 @@ cr.define('options.search_engines', function() {
// Add the favicon.
var faviconDivEl = this.ownerDocument.createElement('div');
faviconDivEl.className = 'favicon';
- if (!this.isPlaceholder) {
- faviconDivEl.style.backgroundImage = imageset(
- 'chrome://favicon/size/16@scalefactorx/iconurl/' + engine.iconURL);
- }
+ if (!this.isPlaceholder)
+ faviconDivEl.style.backgroundImage = getFaviconImageSet(engine.iconURL);
+
nameColEl.appendChild(faviconDivEl);
var nameEl = this.createEditableTextCell(engine.displayName);
« no previous file with comments | « no previous file | chrome/test/data/webui/util_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698