Start adding a DEPS rule to lock down files that we will move out to services/network.

Start adding a DEPS rule to lock down files that we will move out to services/network.

BUG=598073
Committed: https://crrev.com/fbc7e83c202e68f56da71d3fc8f06e58a1807d0c
Cr-Commit-Position: refs/heads/master@{#389901}

[jam, 2016-04-26 20:08:39]

jam@chromium.org changed reviewers:
+ scottmg@chromium.org

[jam, 2016-04-26 20:08:40]

Feel free to critique any files that we shouldn't move out.

[scottmg, 2016-04-26 20:17:02]

lgtm

https://codereview.chromium.org/1914063003/diff/1/content/browser/loader/DEPS
File content/browser/loader/DEPS (right):

https://codereview.chromium.org/1914063003/diff/1/content/browser/loader/DEPS...
content/browser/loader/DEPS:31: "+content/public/common/referrer.h",
I added this one to the move pile in content/public/common, hopefully moveable.

https://codereview.chromium.org/1914063003/diff/1/content/browser/loader/DEPS...
content/browser/loader/DEPS:35: "+content/browser/frame_host/frame_tree_node.h",
Make these ! instead of +.

[jam, 2016-04-26 21:11:44]

The CQ bit was checked by jam@chromium.org

[jam, 2016-04-26 21:11:51]

The CQ bit was unchecked by jam@chromium.org

[jam, 2016-04-26 21:31:27]

https://codereview.chromium.org/1914063003/diff/1/content/browser/loader/DEPS
File content/browser/loader/DEPS (right):

https://codereview.chromium.org/1914063003/diff/1/content/browser/loader/DEPS...
content/browser/loader/DEPS:31: "+content/public/common/referrer.h",
On 2016/04/26 20:17:02, scottmg wrote:
> I added this one to the move pile in content/public/common, hopefully
moveable.

Acknowledged.

https://codereview.chromium.org/1914063003/diff/1/content/browser/loader/DEPS...
content/browser/loader/DEPS:35: "+content/browser/frame_host/frame_tree_node.h",
On 2016/04/26 20:17:02, scottmg wrote:
> Make these ! instead of +.

that is helpful per directory, to ensure that no more files add a header we're
trying to remove. what would we gain by adding it per file?

[scottmg, 2016-04-26 21:36:23]

https://codereview.chromium.org/1914063003/diff/1/content/browser/loader/DEPS
File content/browser/loader/DEPS (right):

https://codereview.chromium.org/1914063003/diff/1/content/browser/loader/DEPS...
content/browser/loader/DEPS:35: "+content/browser/frame_host/frame_tree_node.h",
On 2016/04/26 21:31:27, jam wrote:
> On 2016/04/26 20:17:02, scottmg wrote:
> > Make these ! instead of +.
> 
> that is helpful per directory, to ensure that no more files add a header we're
> trying to remove. what would we gain by adding it per file?

more for intent here, as compared with +s, but doesn't matter, you're right.

[jam, 2016-04-26 21:38:37]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-04-26 21:39:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1914063003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1914063003/1

[commit-bot: I haz the power, 2016-04-26 21:45:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-26 21:46:46]

Description was changed from

==========
Start adding a DEPS rule to lock down files that we will move out to
services/network.

BUG=598073
==========

to

==========
Start adding a DEPS rule to lock down files that we will move out to
services/network.

BUG=598073

Committed: https://crrev.com/fbc7e83c202e68f56da71d3fc8f06e58a1807d0c
Cr-Commit-Position: refs/heads/master@{#389901}
==========

[commit-bot: I haz the power, 2016-04-26 21:46:47]

Patchset 1 (id:??) landed as
https://crrev.com/fbc7e83c202e68f56da71d3fc8f06e58a1807d0c
Cr-Commit-Position: refs/heads/master@{#389901}

[scottmg, 2016-04-27 17:44:35]

https://codereview.chromium.org/1914063003/diff/1/content/browser/loader/DEPS
File content/browser/loader/DEPS (right):

https://codereview.chromium.org/1914063003/diff/1/content/browser/loader/DEPS...
content/browser/loader/DEPS:11: "resource_buffer*\.(cc|h)": [
I think the * on this line is wrong, these are regexes (?), so it'd have to be
.* (i.e. I don't think this is affecting resource_buffer_unittest.cc)