Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: content/browser/loader/DEPS

Issue 1914063003: Start adding a DEPS rule to lock down files that we will move out to services/network. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/DEPS
diff --git a/content/browser/loader/DEPS b/content/browser/loader/DEPS
new file mode 100644
index 0000000000000000000000000000000000000000..df3734a46de85727d538e93780c3f2934b01351d
--- /dev/null
+++ b/content/browser/loader/DEPS
@@ -0,0 +1,43 @@
+# The core loading code in this directory is being transitioned into a separate
+# Mojo networking service. See http://crbug.com/598073. The first stage is to
+# decouple the code that will be moved from the rest of content. These rules
+# help ensure that we don't add more includes, and can progressively reduce the
+# code's dependencies.
+#
+# For each file, the first section shows includes that are allowed (i.e. because
+# they are for files that will be moving as well). The second section, separated
+# by a comment, lists files that we will have to decouple.
+specific_include_rules = {
+ "resource_buffer*\.(cc|h)": [
scottmg 2016/04/27 17:44:35 I think the * on this line is wrong, these are reg
+ "-content",
+ "+content/browser/loader/resource_buffer.h",
+ "+content/common/content_export.h",
+ ],
+ "resource_handler\.(cc|h)": [
+ "-content",
+ "+content/browser/loader/resource_handler.h",
+ "+content/browser/loader/resource_request_info_impl.h",
+ "+content/common/content_export.h",
+ ],
+ "resource_request_info_impl\.(cc|h)": [
+ "-content",
+ "+content/browser/loader/global_routing_id.h",
+ "+content/browser/loader/resource_handler.h",
+ "+content/browser/loader/resource_message_filter.h",
+ "+content/browser/loader/resource_request_info_impl.h",
+ "+content/common/content_export.h",
+ "+content/public/browser/global_request_id.h",
+ "+content/public/browser/resource_request_info.h",
+ "+content/public/common/referrer.h",
scottmg 2016/04/26 20:17:02 I added this one to the move pile in content/publi
jam 2016/04/26 21:31:27 Acknowledged.
+ "+content/public/common/resource_type.h",
+
+ # TODO: these all have to be removed.
+ "+content/browser/frame_host/frame_tree_node.h",
scottmg 2016/04/26 20:17:02 Make these ! instead of +.
jam 2016/04/26 21:31:27 that is helpful per directory, to ensure that no m
scottmg 2016/04/26 21:36:23 more for intent here, as compared with +s, but doe
+ "+content/browser/web_contents/web_contents_impl.h",
+ "+content/common/net/url_request_service_worker_data.h",
+ "+content/common/net/url_request_user_data.h",
+ "+content/public/browser/browser_thread.h",
+ "+content/public/common/browser_side_navigation_policy.h",
+ "+content/public/common/process_type.h",
+ ],
+}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698