Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 1914053004: Remove unnessary uniform barriers in Vulkan. (Closed)

Created:
4 years, 8 months ago by egdaniel
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unnessary uniform barriers in Vulkan. Also added a fix to descriptor set allocation. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1914053004 Committed: https://skia.googlesource.com/skia/+/b1b59576baf8abe457be159b13438b8668f8eeac

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -35 lines) Patch
M src/gpu/vk/GrVkGpu.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M src/gpu/vk/GrVkPipelineState.cpp View 1 3 chunks +3 lines, -17 lines 0 comments Download
M src/gpu/vk/GrVkPipelineStateDataManager.cpp View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
egdaniel
Barrier changes are based off of email thread.
4 years, 8 months ago (2016-04-26 14:26:41 UTC) #3
jvanverth1
lgtm
4 years, 8 months ago (2016-04-26 14:36:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914053004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914053004/20001
4 years, 8 months ago (2016-04-26 14:37:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot/builds/1095)
4 years, 8 months ago (2016-04-26 14:43:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914053004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914053004/20001
4 years, 8 months ago (2016-04-26 15:03:50 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 15:15:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b1b59576baf8abe457be159b13438b8668f8eeac

Powered by Google App Engine
This is Rietveld 408576698