Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1914023002: [DevTools] Apply emulation root layer transform to innerViewportContainerLayer. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
bokan
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Apply emulation root layer transform to innerViewportContainerLayer. This should not affect anything since innerViewportContainerLayer is the only child of root layer. On the other side, cc adds a second child - hud layer, which should not be affected by emulation transform. This patch fixes the problem and enables "show fps meter" together with emulation. BUG=386508 Committed: https://crrev.com/99170fbafe811791bd3666f3b76b647223999445 Cr-Commit-Position: refs/heads/master@{#389983}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M third_party/WebKit/Source/web/DevToolsEmulator.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 3 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 6 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914023002/1
4 years, 7 months ago (2016-04-25 23:01:11 UTC) #2
dgozman
David, could you please take a look? I'm wondering why do we have both rootLayer ...
4 years, 7 months ago (2016-04-25 23:04:06 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-26 00:49:19 UTC) #6
bokan
lgtm % nit https://codereview.chromium.org/1914023002/diff/1/third_party/WebKit/Source/web/WebViewImpl.h File third_party/WebKit/Source/web/WebViewImpl.h (right): https://codereview.chromium.org/1914023002/diff/1/third_party/WebKit/Source/web/WebViewImpl.h#newcode721 third_party/WebKit/Source/web/WebViewImpl.h:721: GraphicsLayer* m_containerLayer; Please make this more ...
4 years, 7 months ago (2016-04-26 15:29:12 UTC) #7
dgozman
Thanks! https://codereview.chromium.org/1914023002/diff/1/third_party/WebKit/Source/web/WebViewImpl.h File third_party/WebKit/Source/web/WebViewImpl.h (right): https://codereview.chromium.org/1914023002/diff/1/third_party/WebKit/Source/web/WebViewImpl.h#newcode721 third_party/WebKit/Source/web/WebViewImpl.h:721: GraphicsLayer* m_containerLayer; On 2016/04/26 15:29:12, bokan wrote: > ...
4 years, 7 months ago (2016-04-27 01:31:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914023002/20001
4 years, 7 months ago (2016-04-27 01:31:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-27 03:36:39 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 03:38:09 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/99170fbafe811791bd3666f3b76b647223999445
Cr-Commit-Position: refs/heads/master@{#389983}

Powered by Google App Engine
This is Rietveld 408576698