Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1671)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 1914023002: [DevTools] Apply emulation root layer transform to innerViewportContainerLayer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed review comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 177e759a28efd2a8e1814138bbff0e5fc846cfab..d4e83cf4b79025d5be58783ddfc9fcaa81b71d16 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -428,11 +428,11 @@ WebViewImpl::WebViewImpl(WebViewClient* client)
, m_layerTreeView(nullptr)
, m_rootLayer(nullptr)
, m_rootGraphicsLayer(nullptr)
+ , m_visualViewportContainerLayer(nullptr)
, m_matchesHeuristicsForGpuRasterization(false)
, m_flingModifier(0)
, m_flingSourceDevice(WebGestureDeviceUninitialized)
, m_fullscreenController(FullscreenController::create(this))
- , m_showFPSCounter(false)
, m_baseBackgroundColor(Color::white)
, m_backgroundColorOverride(Color::transparent)
, m_zoomFactorOverride(0)
@@ -1016,9 +1016,8 @@ void WebViewImpl::setShowFPSCounter(bool show)
{
if (m_layerTreeView) {
TRACE_EVENT0("blink", "WebViewImpl::setShowFPSCounter");
- m_layerTreeView->setShowFPSCounter(show && !m_devToolsEmulator->deviceEmulationEnabled());
+ m_layerTreeView->setShowFPSCounter(show);
}
- m_showFPSCounter = show;
}
void WebViewImpl::setShowPaintRects(bool show)
@@ -1036,12 +1035,6 @@ void WebViewImpl::setShowDebugBorders(bool show)
m_layerTreeView->setShowDebugBorders(show);
}
-void WebViewImpl::updateShowFPSCounter()
-{
- if (m_layerTreeView)
- m_layerTreeView->setShowFPSCounter(m_showFPSCounter && !m_devToolsEmulator->deviceEmulationEnabled());
-}
-
void WebViewImpl::setShowScrollBottleneckRects(bool show)
{
if (m_layerTreeView)
@@ -4169,6 +4162,7 @@ void WebViewImpl::setRootGraphicsLayer(GraphicsLayer* layer)
visualViewport.attachToLayerTree(layer);
if (layer) {
m_rootGraphicsLayer = visualViewport.rootGraphicsLayer();
+ m_visualViewportContainerLayer = visualViewport.containerLayer();
m_rootLayer = m_rootGraphicsLayer->platformLayer();
updateRootLayerTransform();
m_layerTreeView->setRootLayer(*m_rootLayer);
@@ -4183,6 +4177,7 @@ void WebViewImpl::setRootGraphicsLayer(GraphicsLayer* layer)
m_layerTreeView->setVisible(page()->isPageVisible());
} else {
m_rootGraphicsLayer = nullptr;
+ m_visualViewportContainerLayer = nullptr;
m_rootLayer = nullptr;
// This means that we're transitioning to a new page. Suppress
// commits until Blink generates invalidations so we don't
@@ -4334,11 +4329,11 @@ void WebViewImpl::updateLayerTreeDeviceScaleFactor()
void WebViewImpl::updateRootLayerTransform()
{
- if (m_rootGraphicsLayer) {
+ if (m_visualViewportContainerLayer) {
TransformationMatrix transform;
transform.translate(m_rootLayerOffset.width, m_rootLayerOffset.height);
transform = transform.scale(m_rootLayerScale);
- m_rootGraphicsLayer->setTransform(transform);
+ m_visualViewportContainerLayer->setTransform(transform);
}
}
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698