Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1913743002: Add another dollop of sk_sp to SkSpecialImage and SkSpecialSurface (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add another dollop of sk_sp to SkSpecialImage and SkSpecialSurface This is split out of https://codereview.chromium.org/1914883002/ (Refactor drawContext/RenderTarget creation) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1913743002 Committed: https://skia.googlesource.com/skia/+/c91fd3447e1d3452d5e43e70e371896c80645b61

Patch Set 1 #

Patch Set 2 : Fix no-gpu build #

Patch Set 3 : rm std::move #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -102 lines) Patch
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkSpecialImage.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M src/core/SkSpecialImage.cpp View 1 2 14 chunks +35 lines, -39 lines 0 comments Download
M src/core/SkSpecialSurface.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/core/SkSpecialSurface.cpp View 1 3 chunks +10 lines, -22 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/ImageFilterCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
M tests/SpecialImageTest.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M tests/SpecialSurfaceTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 29 (16 generated)
robertphillips
4 years, 8 months ago (2016-04-25 14:52:51 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913743002/1
4 years, 8 months ago (2016-04-25 14:53:08 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/2161)
4 years, 8 months ago (2016-04-25 14:55:40 UTC) #9
reed1
api lgtm lucky if/that you can make the change and not need a guard for ...
4 years, 8 months ago (2016-04-25 15:04:02 UTC) #10
robertphillips
On 2016/04/25 15:04:02, reed1 wrote: > api lgtm > > lucky if/that you can make ...
4 years, 8 months ago (2016-04-25 15:04:53 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913743002/1
4 years, 8 months ago (2016-04-25 16:57:43 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/8047)
4 years, 8 months ago (2016-04-25 17:02:10 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913743002/20001
4 years, 8 months ago (2016-04-25 18:33:50 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot/builds/3127)
4 years, 8 months ago (2016-04-25 18:35:41 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913743002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913743002/60001
4 years, 8 months ago (2016-04-25 19:12:37 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-25 19:26:09 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913743002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913743002/60001
4 years, 8 months ago (2016-04-25 19:32:00 UTC) #27
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 19:32:58 UTC) #29
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://skia.googlesource.com/skia/+/c91fd3447e1d3452d5e43e70e371896c80645b61

Powered by Google App Engine
This is Rietveld 408576698