Add another dollop of sk_sp to SkSpecialImage and SkSpecialSurface

src/core/SkSpecialImage.cpp

 /*
  * Copyright 2016 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file
  */
 #include "SkSpecialImage.h"
 
 #if SK_SUPPORT_GPU
 #include "GrTexture.h"
@@ skipping 14 matching lines @@
         : INHERITED(subset, uniqueID, props) {
     }
     ~SkSpecialImage_Base() override { }
 
     virtual void onDraw(SkCanvas*, SkScalar x, SkScalar y, const SkPaint*) const = 0;
 
     virtual bool onGetROPixels(SkBitmap*) const = 0;
 
     virtual GrTexture* onPeekTexture() const { return nullptr; }
 
-    virtual GrTexture* onAsTextureRef(GrContext* context) const = 0;
+#if SK_SUPPORT_GPU
+    virtual sk_sp<GrTexture> onAsTextureRef(GrContext* context) const = 0;
+#endif
 
     // Delete this entry point ASAP (see skbug.com/4965)
     virtual bool getBitmapDeprecated(SkBitmap* result) const = 0;
 
     virtual sk_sp<SkSpecialImage> onMakeSubset(const SkIRect& subset) const = 0;
 
     virtual sk_sp<SkSpecialSurface> onMakeSurface(const SkImageInfo& info) const = 0;
 
     virtual sk_sp<SkImage> onMakeTightSubset(const SkIRect& subset) const = 0;
 
@@ skipping 27 matching lines @@
 
     SkBitmap bmp;
     if (!this->internal_getBM(&bmp)) {
         return nullptr;
     }
 
     if (bmp.empty()) {
         return SkSpecialImage::MakeFromRaster(SkIRect::MakeEmpty(), bmp, &this->props());
     }
 
-    SkAutoTUnref<GrTexture> resultTex(
-        GrRefCachedBitmapTexture(context, bmp, GrTextureParams::ClampNoFilter()));
+    sk_sp<GrTexture> resultTex(GrRefCachedBitmapTexture(context,
+                                                        bmp,
+                                                        GrTextureParams::ClampNoFilter()));
     if (!resultTex) {
         return nullptr;
     }
 
     SkAlphaType at = this->isOpaque() ? kOpaque_SkAlphaType : kPremul_SkAlphaType;
 
     return SkSpecialImage::MakeFromGpu(SkIRect::MakeWH(resultTex->width(), resultTex->height()),
                                        this->uniqueID(),
                                        resultTex, &this->props(), at);
 #else
@@ skipping 21 matching lines @@
 #if SK_SUPPORT_GPU
     GrTexture* texture = as_SIB(this)->onPeekTexture();
     
     if (texture) {
         return texture->getContext();
     }
 #endif
     return nullptr;
 }
 
-
-GrTexture* SkSpecialImage::asTextureRef(GrContext* context) const {
+#if SK_SUPPORT_GPU
+sk_sp<GrTexture> SkSpecialImage::asTextureRef(GrContext* context) const {
     return as_SIB(this)->onAsTextureRef(context);
 }
+#endif
 
 sk_sp<SkSpecialSurface> SkSpecialImage::makeSurface(const SkImageInfo& info) const {
     return as_SIB(this)->onMakeSurface(info);
 }
 
 sk_sp<SkSurface> SkSpecialImage::makeTightSurface(const SkImageInfo& info) const {
     return as_SIB(this)->onMakeTightSurface(info);
 }
 
 sk_sp<SkSpecialImage> SkSpecialImage::makeSubset(const SkIRect& subset) const {
     return as_SIB(this)->onMakeSubset(subset);
 }
 
 sk_sp<SkImage> SkSpecialImage::makeTightSubset(const SkIRect& subset) const {
     return as_SIB(this)->onMakeTightSubset(subset);
 }
 
 #if SK_SUPPORT_GPU
 #include "SkGr.h"
 #include "SkGrPixelRef.h"
 #endif
 
 sk_sp<SkSpecialImage> SkSpecialImage::internal_fromBM(const SkBitmap& src,
                                                       const SkSurfaceProps* props) {
+#if SK_SUPPORT_GPU
     // Need to test offset case! (see skbug.com/4967)
     if (src.getTexture()) {
         return SkSpecialImage::MakeFromGpu(src.bounds(),
                                            src.getGenerationID(),
-                                           src.getTexture(),
+                                           sk_ref_sp(src.getTexture()),
                                            props);
     }
+#endif
 
     return SkSpecialImage::MakeFromRaster(src.bounds(), src, props);
 }
 
 bool SkSpecialImage::internal_getBM(SkBitmap* result) {
     const SkSpecialImage_Base* ib = as_SIB(this);
 
     // TODO: need to test offset case! (see skbug.com/4967)
     return ib->getBitmapDeprecated(result);
 }
@@ skipping 39 matching lines @@
         canvas->drawImageRect(fImage.get(), this->subset(),
                               dst, paint, SkCanvas::kStrict_SrcRectConstraint);
     }
 
     bool onGetROPixels(SkBitmap* bm) const override {
         return as_IB(fImage)->getROPixels(bm);
     }
 
     GrTexture* onPeekTexture() const override { return as_IB(fImage)->peekTexture(); }
 
-    GrTexture* onAsTextureRef(GrContext* context) const override {
 #if SK_SUPPORT_GPU
-        return as_IB(fImage)->asTextureRef(context, GrTextureParams::ClampNoFilter());
-#else
-        return nullptr;
+    sk_sp<GrTexture> onAsTextureRef(GrContext* context) const override {
+        return sk_sp<GrTexture>(as_IB(fImage)->asTextureRef(context,
+                                                            GrTextureParams::ClampNoFilter()));
+    }
 #endif
-    }
 
     bool getBitmapDeprecated(SkBitmap* result) const override {
 #if SK_SUPPORT_GPU
         if (GrTexture* texture = as_IB(fImage.get())->peekTexture()) {
             const SkImageInfo info = GrMakeInfoFromTexture(texture,
                                                            fImage->width(), fImage->height(),
                                                            fImage->isOpaque());
             if (!result->setInfo(info)) {
                 return false;
             }
@@ skipping 112 matching lines @@
 
         canvas->drawBitmapRect(fBitmap, this->subset(),
                                dst, paint, SkCanvas::kStrict_SrcRectConstraint);
     }
 
     bool onGetROPixels(SkBitmap* bm) const override {
         *bm = fBitmap;
         return true;
     }
 
-    GrTexture* onAsTextureRef(GrContext* context) const override {
 #if SK_SUPPORT_GPU
+    sk_sp<GrTexture> onAsTextureRef(GrContext* context) const override {
         if (context) {
-            return GrRefCachedBitmapTexture(context, fBitmap, GrTextureParams::ClampNoFilter());
+            return sk_ref_sp(GrRefCachedBitmapTexture(context,
+                                                      fBitmap,
+                                                      GrTextureParams::ClampNoFilter()));
         }
-#endif
 
         return nullptr;
     }
+#endif
 
     bool getBitmapDeprecated(SkBitmap* result) const override {
         *result = fBitmap;
         return true;
     }
 
     sk_sp<SkSpecialSurface> onMakeSurface(const SkImageInfo& info) const override {
         return SkSpecialSurface::MakeRaster(info, nullptr);
     }
 
@@ skipping 52 matching lines @@
 
 
 #if SK_SUPPORT_GPU
 ///////////////////////////////////////////////////////////////////////////////
 #include "GrTexture.h"
 #include "SkImage_Gpu.h"
 
 class SkSpecialImage_Gpu : public SkSpecialImage_Base {
 public:
     SkSpecialImage_Gpu(const SkIRect& subset,
-                       uint32_t uniqueID, GrTexture* tex, SkAlphaType at,
+                       uint32_t uniqueID, sk_sp<GrTexture> tex, SkAlphaType at,
                        const SkSurfaceProps* props)
         : INHERITED(subset, uniqueID, props)
-        , fTexture(SkRef(tex))
+        , fTexture(std::move(tex))
         , fAlphaType(at)
         , fAddedRasterVersionToCache(false) {
     }
 
     ~SkSpecialImage_Gpu() override {
         if (fAddedRasterVersionToCache.load()) {
             SkNotifyBitmapGenIDIsStale(this->uniqueID());
         }
     }
 
     bool isOpaque() const override {
         return GrPixelConfigIsOpaque(fTexture->config()) || fAlphaType == kOpaque_SkAlphaType;
     }
 
     size_t getSize() const override { return fTexture->gpuMemorySize(); }
 
     void onDraw(SkCanvas* canvas, SkScalar x, SkScalar y, const SkPaint* paint) const override {
         SkRect dst = SkRect::MakeXYWH(x, y,
                                       this->subset().width(), this->subset().height());
 
         SkBitmap bm;
 
-        GrWrapTextureInBitmap(fTexture,
+        GrWrapTextureInBitmap(fTexture.get(),
                               fTexture->width(), fTexture->height(), this->isOpaque(), &bm);
 
         canvas->drawBitmapRect(bm, this->subset(),
                                dst, paint, SkCanvas::kStrict_SrcRectConstraint);
     }
 
-    GrTexture* onPeekTexture() const override { return fTexture; }
+    GrTexture* onPeekTexture() const override { return fTexture.get(); }
 
-    GrTexture* onAsTextureRef(GrContext*) const override { return SkRef(fTexture.get()); }
+    sk_sp<GrTexture> onAsTextureRef(GrContext*) const override { return fTexture; }
 
     bool onGetROPixels(SkBitmap* dst) const override {
         if (SkBitmapCache::Find(this->uniqueID(), dst)) {
             SkASSERT(dst->getGenerationID() == this->uniqueID());
             SkASSERT(dst->isImmutable());
             SkASSERT(dst->getPixels());
             return true;
         }
 
         SkImageInfo info = SkImageInfo::MakeN32(this->width(), this->height(),
                                                 this->isOpaque() ? kOpaque_SkAlphaType
                                                                  : kPremul_SkAlphaType);
 
         if (!dst->tryAllocPixels(info)) {
             return false;
         }
 
         if (!fTexture->readPixels(0, 0, dst->width(), dst->height(), kSkia8888_GrPixelConfig,
                                   dst->getPixels(), dst->rowBytes())) {
             return false;
         }
 
         dst->pixelRef()->setImmutableWithID(this->uniqueID());
         SkBitmapCache::Add(this->uniqueID(), *dst);
         fAddedRasterVersionToCache.store(true);
         return true;
     }
 
     bool getBitmapDeprecated(SkBitmap* result) const override {
-        const SkImageInfo info = GrMakeInfoFromTexture(fTexture,
+        const SkImageInfo info = GrMakeInfoFromTexture(fTexture.get(),
                                                        this->width(), this->height(),
                                                        this->isOpaque());
         if (!result->setInfo(info)) {
             return false;
         }
 
         const SkImageInfo prInfo = info.makeWH(fTexture->width(), fTexture->height());
 
-        SkAutoTUnref<SkGrPixelRef> pixelRef(new SkGrPixelRef(prInfo, fTexture));
+        SkAutoTUnref<SkGrPixelRef> pixelRef(new SkGrPixelRef(prInfo, fTexture.get()));
         result->setPixelRef(pixelRef, this->subset().fLeft, this->subset().fTop);
         return true;
     }
 
     sk_sp<SkSpecialSurface> onMakeSurface(const SkImageInfo& info) const override {
         if (!fTexture->getContext()) {
             return nullptr;
         }
 
         GrSurfaceDesc desc = GrImageInfoToSurfaceDesc(info, *fTexture->getContext()->caps());
@@ skipping 10 matching lines @@
                                            fAlphaType);
     }
 
     sk_sp<SkImage> onMakeTightSubset(const SkIRect& subset) const override {
         if (0 == subset.fLeft && 0 == subset.fTop &&
             fTexture->width() == subset.width() &&
             fTexture->height() == subset.height()) {
             // The existing GrTexture is already tight so reuse it in the SkImage
             return sk_make_sp<SkImage_Gpu>(fTexture->width(), fTexture->height(),
                                            kNeedNewImageUniqueID,
-                                           fAlphaType, fTexture, SkBudgeted::kYes);
+                                           fAlphaType, fTexture.get(), SkBudgeted::kYes);
         }
 
         GrContext* ctx = fTexture->getContext();
         GrSurfaceDesc desc = fTexture->desc();
         desc.fWidth = subset.width();
         desc.fHeight = subset.height();
 
-        SkAutoTUnref<GrTexture> subTx(ctx->textureProvider()->createTexture(desc,
-                                                                            SkBudgeted::kYes));
+        sk_sp<GrTexture> subTx(ctx->textureProvider()->createTexture(desc, SkBudgeted::kYes));
         if (!subTx) {
             return nullptr;
         }
-        ctx->copySurface(subTx, fTexture, subset, SkIPoint::Make(0, 0));
+        ctx->copySurface(subTx.get(), fTexture.get(), subset, SkIPoint::Make(0, 0));
         return sk_make_sp<SkImage_Gpu>(desc.fWidth, desc.fHeight, kNeedNewImageUniqueID,
-                                       fAlphaType, subTx, SkBudgeted::kYes);
+                                       fAlphaType, subTx.get(), SkBudgeted::kYes);
     }
 
     sk_sp<SkSurface> onMakeTightSurface(const SkImageInfo& info) const override {
         return SkSurface::MakeRenderTarget(fTexture->getContext(), SkBudgeted::kYes, info);
     }
 
 private:
-    SkAutoTUnref<GrTexture> fTexture;
+    sk_sp<GrTexture>        fTexture;
     const SkAlphaType       fAlphaType;
     mutable SkAtomic<bool>  fAddedRasterVersionToCache;
 
     typedef SkSpecialImage_Base INHERITED;
 };
 
 sk_sp<SkSpecialImage> SkSpecialImage::MakeFromGpu(const SkIRect& subset,
                                                   uint32_t uniqueID,
-                                                  GrTexture* tex,
+                                                  sk_sp<GrTexture> tex,
                                                   const SkSurfaceProps* props,
                                                   SkAlphaType at) {
     SkASSERT(rect_fits(subset, tex->width(), tex->height()));
-    return sk_make_sp<SkSpecialImage_Gpu>(subset, uniqueID, tex, at, props);
-}
-
-#else
-
-sk_sp<SkSpecialImage> SkSpecialImage::MakeFromGpu(const SkIRect& subset,
-                                                  uint32_t uniqueID,
-                                                  GrTexture* tex,
-                                                  const SkSurfaceProps* props,
-                                                  SkAlphaType at) {
-    return nullptr;
+    return sk_make_sp<SkSpecialImage_Gpu>(subset, uniqueID, std::move(tex), at, props);
 }
 
 #endif