Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3973)

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer.cc

Issue 1913693002: Histogram the amount of time spent on HTTP(S) page loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Equality operations are hard, let's go trybotting Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/browser/metrics_web_contents_observer.cc
diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.cc b/components/page_load_metrics/browser/metrics_web_contents_observer.cc
index 0f40c4ba17a3c29ea60e852e49da36ff7a357de7..7678a3f4ace6e08330d369f04b13909e94293bf4 100644
--- a/components/page_load_metrics/browser/metrics_web_contents_observer.cc
+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.cc
@@ -253,7 +253,8 @@ PageLoadTracker::PageLoadTracker(
DCHECK(!navigation_handle->HasCommitted());
embedder_interface_->RegisterObservers(this);
for (const auto& observer : observers_) {
- observer->OnStart(navigation_handle, currently_committed_url);
+ observer->OnStart(navigation_handle, currently_committed_url,
+ started_in_foreground_);
}
}
@@ -328,6 +329,9 @@ void PageLoadTracker::WebContentsHidden() {
DCHECK_EQ(started_in_foreground_, foreground_time_.is_null());
background_time_ = base::TimeTicks::Now();
}
+
+ for (const auto& observer : observers_)
+ observer->OnHidden();
}
void PageLoadTracker::WebContentsShown() {
@@ -339,6 +343,9 @@ void PageLoadTracker::WebContentsShown() {
DCHECK_NE(started_in_foreground_, background_time_.is_null());
foreground_time_ = base::TimeTicks::Now();
}
+
+ for (const auto& observer : observers_)
+ observer->OnShown();
}
void PageLoadTracker::Commit(content::NavigationHandle* navigation_handle) {
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698