components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc - Issue 1913693002: Histogram the amount of time spent on HTTP(S) page loads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

Issue 1913693002: Histogram the amount of time spent on HTTP(S) page loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Equality operations are hard, let's go trybotting Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/page_load_metrics/browser/metrics_web_contents_observer.cc ('k') | components/page_load_metrics/browser/page_load_metrics_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc b/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

index 7130c8831c483fb590fcb7ed823691c0ebf9cf6b..993a0f2fc4e22e297165acc10cb54e5945fec38f 100644

--- a/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

+++ b/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

@@ -42,7 +42,8 @@ class TestPageLoadMetricsObserver : public PageLoadMetricsObserver {

observed_committed_urls_(observed_committed_urls) {}

void OnStart(content::NavigationHandle* navigation_handle,

- const GURL& currently_committed_url) override {

+ const GURL& currently_committed_url,

+ bool started_in_foreground) override {

observed_committed_urls_->push_back(currently_committed_url);

}