Close IME on tapping on Blimp web content pane

blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java

Index: blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java
diff --git a/blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java b/blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java
index 212d15db17a1b7d194ef1ba018f79d0cd08b9da8..69b697b4f408d4b120bbba75756933e2039bedf0 100644
--- a/blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java
+++ b/blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java
@@ -16,6 +16,7 @@ import android.view.WindowManager;
 
 import org.chromium.base.annotations.JNINamespace;
 import org.chromium.blimp.session.BlimpClientSession;
+import org.chromium.ui.UiUtils;
 
 /**
  * A {@link View} that will visually represent the Blimp rendered content.  This {@link View} starts
@@ -23,6 +24,7 @@ import org.chromium.blimp.session.BlimpClientSession;
  */
 @JNINamespace("blimp::client")
 public class BlimpView extends SurfaceView implements SurfaceHolder.Callback {
+    private static final String TAG = "BlimpView";

[Khushal, 2016/04/23 01:29:21]

nit: Unused.

[shaktisahu, 2016/04/23 02:08:05]

Just added to help in debugging and logging. I think most of the Android classes
use this convention.

[nyquist, 2016/04/26 18:28:58]

Yeah, but we usually remove it if it ends up not being used in production code.

[shaktisahu, 2016/04/26 20:06:42]

Done.

     private long mNativeBlimpViewPtr;
 
     /**
@@ -96,6 +98,12 @@ public class BlimpView extends SurfaceView implements SurfaceHolder.Callback {
 
         int eventAction = event.getActionMasked();
 
+        // Close the IME. It might be open for typing URL into toolbar.
+        // TODO(shaktisahu): Detect if the IME was open and return immediately.

[Khushal, 2016/04/23 01:29:21]

Could we use UiUtils.isKeyboardShowing for this instead?

[shaktisahu, 2016/04/23 02:08:05]

I tried using that. Seems like this method isn't able to detect if the keyboard
is open because of some soft input adjustment configuration we are currently
using.

+        if (eventAction == MotionEvent.ACTION_UP) {

[Khushal, 2016/04/23 01:29:21]

Why do this only for ACTION_UP? If the user tries to scroll, we should hide the
IME in that case as well.

[shaktisahu, 2016/04/23 02:08:05]

Good catch. Initially, I didn't want to call this twice for every tap. Now I
think it's better to remove the condition.

+            UiUtils.hideKeyboard(this);
+        }
+
         if (!isValidTouchEventActionForNative(eventAction)) return false;
 
         int pointerCount = event.getPointerCount();