Close IME on tapping on Blimp web content pane

blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.blimp;
 
 import android.content.Context;
 import android.graphics.Point;
 import android.os.Build;
 import android.util.AttributeSet;
 import android.view.MotionEvent;
 import android.view.Surface;
 import android.view.SurfaceHolder;
 import android.view.SurfaceView;
 import android.view.WindowManager;
 
 import org.chromium.base.annotations.JNINamespace;
 import org.chromium.blimp.session.BlimpClientSession;
+import org.chromium.ui.UiUtils;
 
 /**
  * A {@link View} that will visually represent the Blimp rendered content.  This {@link View} starts
  * a native compositor.
  */
 @JNINamespace("blimp::client")
 public class BlimpView extends SurfaceView implements SurfaceHolder.Callback {
+    private static final String TAG = "BlimpView";

[Khushal, 2016/04/23 01:29:21]

nit: Unused.

[shaktisahu, 2016/04/23 02:08:05]

Just added to help in debugging and logging. I think most of the Android classes
use this convention.

[nyquist, 2016/04/26 18:28:58]

Yeah, but we usually remove it if it ends up not being used in production code.

[shaktisahu, 2016/04/26 20:06:42]

Done.

     private long mNativeBlimpViewPtr;
 
     /**
      * Builds a new {@link BlimpView}.
      * @param context A {@link Context} instance.
      * @param attrs   An {@link AttributeSet} instance.
      */
     public BlimpView(Context context, AttributeSet attrs) {
         super(context, attrs);
         setFocusable(true);
@@ skipping 53 matching lines @@
         nativeSetVisibility(mNativeBlimpViewPtr, visible);
     }
 
     // View overrides.
     @Override
     public boolean onTouchEvent(MotionEvent event) {
         if (mNativeBlimpViewPtr == 0) return false;
 
         int eventAction = event.getActionMasked();
 
+        // Close the IME. It might be open for typing URL into toolbar.
+        // TODO(shaktisahu): Detect if the IME was open and return immediately.

[Khushal, 2016/04/23 01:29:21]

Could we use UiUtils.isKeyboardShowing for this instead?

[shaktisahu, 2016/04/23 02:08:05]

I tried using that. Seems like this method isn't able to detect if the keyboard
is open because of some soft input adjustment configuration we are currently
using.

+        if (eventAction == MotionEvent.ACTION_UP) {

[Khushal, 2016/04/23 01:29:21]

Why do this only for ACTION_UP? If the user tries to scroll, we should hide the
IME in that case as well.

[shaktisahu, 2016/04/23 02:08:05]

Good catch. Initially, I didn't want to call this twice for every tap. Now I
think it's better to remove the condition.

+            UiUtils.hideKeyboard(this);
+        }
+
         if (!isValidTouchEventActionForNative(eventAction)) return false;
 
         int pointerCount = event.getPointerCount();
 
         float[] touchMajor = {event.getTouchMajor(), pointerCount > 1 ? event.getTouchMajor(1) : 0};
         float[] touchMinor = {event.getTouchMinor(), pointerCount > 1 ? event.getTouchMinor(1) : 0};
 
         for (int i = 0; i < 2; i++) {
             if (touchMajor[i] < touchMinor[i]) {
                 float tmp = touchMajor[i];
@@ skipping 79 matching lines @@
             float x0, float y0, float x1, float y1,
             int pointerId0, int pointerId1,
             float touchMajor0, float touchMajor1,
             float touchMinor0, float touchMinor1,
             float orientation0, float orientation1,
             float tilt0, float tilt1,
             float rawX, float rawY,
             int androidToolType0, int androidToolType1,
             int androidButtonState, int androidMetaState);
 }