Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1913553002: Fix compile failures from shelf locking merge CL. (Closed)

Created:
4 years, 8 months ago by msw
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fix compile failures from shelf locking merge CL. Fixes a compile failure from the M-51 merge CL: https://codereview.chromium.org/1907363004 See the failure here: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/precise64%20beta/builds/2454 BUG=603243 TEST=Fixes go/betabuilders bots. R=sky@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Patch Set 2 : Update GetAlignment function call. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ash/app_list/app_list_shower_delegate.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/wm/app_list_controller.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
msw
Hey Scott, heads up; building locally now, will land asap.
4 years, 8 months ago (2016-04-22 20:33:28 UTC) #1
sky
LGTM
4 years, 8 months ago (2016-04-22 20:35:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913553002/1
4 years, 8 months ago (2016-04-22 20:39:05 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 8 months ago (2016-04-22 20:39:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913553002/20001
4 years, 8 months ago (2016-04-22 20:44:50 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 20:46:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698