Makes WorkspaceWindowResizer use ash/wm/common types

Makes WorkspaceWindowResizer use ash/wm/common types

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
TBR=reveman@chromium.org

Committed: https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f
Cr-Commit-Position: refs/heads/master@{#389263}

[James Cook, 2016-04-22 20:06:14]

LGTM

https://codereview.chromium.org/1913473002/diff/20001/ash/wm/common/wm_window...
File ash/wm/common/wm_window_tracker.h (right):

https://codereview.chromium.org/1913473002/diff/20001/ash/wm/common/wm_window...
ash/wm/common/wm_window_tracker.h:10: #include "base/macros.h"
Do you need macros.h or compiler_specific.h here?

https://codereview.chromium.org/1913473002/diff/20001/ash/wm/window_resizer.h
File ash/wm/window_resizer.h (right):

https://codereview.chromium.org/1913473002/diff/20001/ash/wm/window_resizer.h...
ash/wm/window_resizer.h:111: // Creates a WindowResizer for |window|. This can
return a scoped_ptr
nit while you're here: scoped_ptr -> unique_ptr

https://codereview.chromium.org/1913473002/diff/20001/ash/wm/workspace/worksp...
File ash/wm/workspace/workspace_window_resizer.cc (right):

https://codereview.chromium.org/1913473002/diff/20001/ash/wm/workspace/worksp...
ash/wm/workspace/workspace_window_resizer.cc:376:
gfx::Screen::GetScreen()->GetDisplayNearestPoint(location_in_screen);
Just to double-check, GetDisplayNearestPoint() always returns a valid display
and it doesn't need the validity test below?

(It looks OK from the couple of Screen implementations I inspected, but it is
not clear to me from the Screen::GetDisplayNearestPoint() header docs.)

[sky, 2016-04-22 20:13:20]

https://codereview.chromium.org/1913473002/diff/20001/ash/wm/common/wm_window...
File ash/wm/common/wm_window_tracker.h (right):

https://codereview.chromium.org/1913473002/diff/20001/ash/wm/common/wm_window...
ash/wm/common/wm_window_tracker.h:10: #include "base/macros.h"
On 2016/04/22 20:06:13, James Cook wrote:
> Do you need macros.h or compiler_specific.h here?

Nope. Nuked.

https://codereview.chromium.org/1913473002/diff/20001/ash/wm/window_resizer.h
File ash/wm/window_resizer.h (right):

https://codereview.chromium.org/1913473002/diff/20001/ash/wm/window_resizer.h...
ash/wm/window_resizer.h:111: // Creates a WindowResizer for |window|. This can
return a scoped_ptr
On 2016/04/22 20:06:13, James Cook wrote:
> nit while you're here: scoped_ptr -> unique_ptr

Done.

https://codereview.chromium.org/1913473002/diff/20001/ash/wm/workspace/worksp...
File ash/wm/workspace/workspace_window_resizer.cc (right):

https://codereview.chromium.org/1913473002/diff/20001/ash/wm/workspace/worksp...
ash/wm/workspace/workspace_window_resizer.cc:376:
gfx::Screen::GetScreen()->GetDisplayNearestPoint(location_in_screen);
On 2016/04/22 20:06:13, James Cook wrote:
> Just to double-check, GetDisplayNearestPoint() always returns a valid display
> and it doesn't need the validity test below?
> 
> (It looks OK from the couple of Screen implementations I inspected, but it is
> not clear to me from the Screen::GetDisplayNearestPoint() header docs.)

That's right, a valid display is always returned.

[sky, 2016-04-22 20:13:48]

The CQ bit was checked by sky@chromium.org

[sky, 2016-04-22 20:13:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/1913473002/#ps40001
(title: "feedback")

[commit-bot: I haz the power, 2016-04-22 20:14:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1913473002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1913473002/40001

[commit-bot: I haz the power, 2016-04-22 20:24:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 20:24:20]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sky, 2016-04-22 20:40:55]

Description was changed from

==========
Makes WorkspaceWindowResizer use ash/wm/common types

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Makes WorkspaceWindowResizer use ash/wm/common types

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
TBR=reveman@chromium.org
==========

[sky, 2016-04-22 20:40:55]

sky@chromium.org changed reviewers:
+ reveman@chromium.org

[sky, 2016-04-22 20:41:06]

TBR reveman for trivial change to exo

[sky, 2016-04-22 20:41:10]

The CQ bit was checked by sky@chromium.org

[sky, 2016-04-22 20:41:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/1913473002/#ps60001
(title: "fix exo")

[commit-bot: I haz the power, 2016-04-22 20:42:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1913473002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1913473002/60001

[commit-bot: I haz the power, 2016-04-22 20:59:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 20:59:56]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-04-22 21:06:27]

The CQ bit was checked by sky@chromium.org

[sky, 2016-04-22 21:06:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/1913473002/#ps80001
(title: "fix exo again")

[commit-bot: I haz the power, 2016-04-22 21:07:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1913473002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1913473002/80001

[commit-bot: I haz the power, 2016-04-22 22:11:33]

Description was changed from

==========
Makes WorkspaceWindowResizer use ash/wm/common types

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
TBR=reveman@chromium.org
==========

to

==========
Makes WorkspaceWindowResizer use ash/wm/common types

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
TBR=reveman@chromium.org
==========

[commit-bot: I haz the power, 2016-04-22 22:11:34]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-22 22:12:46]

Description was changed from

==========
Makes WorkspaceWindowResizer use ash/wm/common types

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
TBR=reveman@chromium.org
==========

to

==========
Makes WorkspaceWindowResizer use ash/wm/common types

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
TBR=reveman@chromium.org

Committed: https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f
Cr-Commit-Position: refs/heads/master@{#389263}
==========

[commit-bot: I haz the power, 2016-04-22 22:12:47]

Patchset 5 (id:??) landed as
https://crrev.com/5c286d4dedd1d2ad7cff16dd77ff2fc04a40b37f
Cr-Commit-Position: refs/heads/master@{#389263}

[reveman, 2016-04-25 08:22:01]

lgtm