Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: chrome/browser/ui/webui/extensions/extensions_ui.cc

Issue 1913353002: [MD Extensions] Add a details subpage, move to one list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extensions_ui.cc
diff --git a/chrome/browser/ui/webui/extensions/extensions_ui.cc b/chrome/browser/ui/webui/extensions/extensions_ui.cc
index 4617611716ba258851878eb6c578177e04497ec0..38f23da259eef5e1c388eae5c11edf7fc493066a 100644
--- a/chrome/browser/ui/webui/extensions/extensions_ui.cc
+++ b/chrome/browser/ui/webui/extensions/extensions_ui.cc
@@ -47,8 +47,6 @@ content::WebUIDataSource* CreateMdExtensionsSource() {
source->AddLocalizedString("sidebarPack", IDS_MD_EXTENSIONS_SIDEBAR_PACK);
source->AddLocalizedString("sidebarUpdateNow",
IDS_MD_EXTENSIONS_SIDEBAR_UPDATE_NOW);
- source->AddLocalizedString("sidebarWebsites",
- IDS_MD_EXTENSIONS_SIDEBAR_WEBSITES);
source->AddLocalizedString("developerMode",
IDS_MD_EXTENSIONS_SIDEBAR_DEVELOPER_MODE);
source->AddLocalizedString("getMoreExtensions",
@@ -60,9 +58,19 @@ content::WebUIDataSource* CreateMdExtensionsSource() {
IDS_MD_EXTENSIONS_ITEM_INSPECT_VIEWS);
source->AddLocalizedString("itemAllowIncognito",
IDS_MD_EXTENSIONS_ITEM_ALLOW_INCOGNITO);
+ source->AddLocalizedString("itemDescriptionLabel",
+ IDS_MD_EXTENSIONS_ITEM_DESCRIPTION);
+ source->AddLocalizedString("itemDependencies",
+ IDS_MD_EXTENSIONS_ITEM_DEPENDENCIES);
source->AddLocalizedString("itemDetails", IDS_MD_EXTENSIONS_ITEM_DETAILS);
source->AddLocalizedString("itemEnabled", IDS_MD_EXTENSIONS_ITEM_ENABLED);
source->AddLocalizedString("itemDisabled", IDS_MD_EXTENSIONS_ITEM_DISABLED);
+ source->AddLocalizedString("itemPermissions",
+ IDS_MD_EXTENSIONS_ITEM_PERMISSIONS);
+ source->AddLocalizedString("itemSource",
+ IDS_MD_EXTENSIONS_ITEM_SOURCE);
+ source->AddLocalizedString("itemVersion",
+ IDS_MD_EXTENSIONS_ITEM_SOURCE);
source->AddLocalizedString("itemCorruptInstall",
IDS_EXTENSIONS_CORRUPTED_EXTENSION);
source->AddString(
@@ -79,6 +87,9 @@ content::WebUIDataSource* CreateMdExtensionsSource() {
source->AddLocalizedString("viewIframe",
IDS_EXTENSIONS_VIEW_IFRAME);
+ source->AddResourcePath("detail_view.html",
+ IDR_MD_EXTENSIONS_DETAIL_VIEW_HTML);
+ source->AddResourcePath("detail_view.js", IDR_MD_EXTENSIONS_DETAIL_VIEW_JS);
source->AddResourcePath("manager.css", IDR_MD_EXTENSIONS_MANAGER_CSS);
source->AddResourcePath("manager.html", IDR_MD_EXTENSIONS_MANAGER_HTML);
source->AddResourcePath("manager.js", IDR_MD_EXTENSIONS_MANAGER_JS);

Powered by Google App Engine
This is Rietveld 408576698