Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: chrome/browser/resources/md_extensions/manager.html

Issue 1913353002: [MD Extensions] Add a details subpage, move to one list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_extensions/manager.html
diff --git a/chrome/browser/resources/md_extensions/manager.html b/chrome/browser/resources/md_extensions/manager.html
index dc736958c583ec08a7e7129fb1238a23b9db4f68..f71e86b059d7f7b1d6705e379b41f1a1bcd32350 100644
--- a/chrome/browser/resources/md_extensions/manager.html
+++ b/chrome/browser/resources/md_extensions/manager.html
@@ -2,6 +2,9 @@
<link rel="import" href="chrome://resources/html/i18n_behavior.html">
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-header-panel/paper-header-panel.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animated-pages.html">
+<link rel="import" href="chrome://extensions/detail_view.html">
<link rel="import" href="chrome://extensions/item_list.html">
<link rel="import" href="chrome://extensions/service.html">
<link rel="import" href="chrome://extensions/sidebar.html">
@@ -12,28 +15,18 @@
<paper-header-panel id="panel">
<extensions-toolbar class="paper-header" id="toolbar">
</extensions-toolbar>
- <extensions-sidebar in-dev-mode="[[inDevMode]]"
- hide-extensions-button="[[computeListHidden_(extensions, extensions.splices)]]"
Devlin 2016/04/23 01:50:11 With separate pages for these, I don't think it ma
- hide-apps-button="[[computeListHidden_(apps, apps.splices)]]"
- hide-websites-button="[[computeListHidden_(websites, websites.splices)]]">
+ <extensions-sidebar in-dev-mode="[[inDevMode]]">
</extensions-sidebar>
- <div id="items">
- <extensions-item-list id="extensions-list" items="[[extensions]]"
+ <neon-animated-pages id="pages" selected="0">
Devlin 2016/04/23 01:50:11 I talked with michaelpg@ about whether or not to u
+ <extensions-item-list id="items-list" items="[[extensions]]"
delegate="[[service]]" header="[[i18n('sidebarExtensions')]]"
in-dev-mode="[[inDevMode]]" filter="[[filter]]"
- hidden$="[[computeListHidden_(extensions, extensions.splices)]]">
+ hidden$="[[computeListHidden_(extensions, extensions.splices, apps, apps.splices)]]">
</extensions-item-list>
- <extensions-item-list id="apps-list" items="[[apps]]"
- delegate="[[service]]" header="[[i18n('sidebarApps')]]"
- in-dev-mode="[[inDevMode]]" filter="[[filter]]"
- hidden$="[[computeListHidden_(apps, apps.splices)]]">
- </extensions-item-list>
- <extensions-item-list id="websites-list" items="[[websites]]"
- delegate="[[service]]" header="[[i18n('sidebarWebsites')]]"
- in-dev-mode="[[inDevMode]]" filter="[[filter]]"
- hidden$="[[computeListHidden_(websites, websites.splices)]]">
- </extensions-item-list>
- </div>
+ <extensions-detail-view id="details-view"
+ on-close="onDetailsViewClose_">
+ </extensions-detail-view>
+ </neon-animated-pages>
</paper-header-panel>
</template>
<link rel="import" type="css" href="chrome://extensions/manager.css">

Powered by Google App Engine
This is Rietveld 408576698