Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/browser/resources/md_extensions/service.js

Issue 1913353002: [MD Extensions] Add a details subpage, move to one list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_extensions/service.js
diff --git a/chrome/browser/resources/md_extensions/service.js b/chrome/browser/resources/md_extensions/service.js
index a0837206eb1194c7e7329a87b1ca9a7552dcfbe4..b0216b426027e4119514e4328af9ca99891cb649 100644
--- a/chrome/browser/resources/md_extensions/service.js
+++ b/chrome/browser/resources/md_extensions/service.js
@@ -111,7 +111,12 @@ cr.define('extensions', function() {
},
/** @override */
- showItemDetails: function(id) {},
+ showItemDetails: function(id) {
+ var data =
+ this.extensions_.filter(function(e) { return e.id === id; })[0];
+ assert(data);
+ this.manager_.showDetailsFor(data);
+ },
/** @override */
setItemAllowedIncognito: function(id, isAllowedIncognito) {

Powered by Google App Engine
This is Rietveld 408576698