Source/core/html/shadow/DateTimeNumericFieldElement.h - Issue 191293011: Value set in onblur should not keep element in focus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/DateTimeNumericFieldElement.h

Issue 191293011: Value set in onblur should not keep element in focus (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: SetFocus handler implementation for DateTimeFieldElement Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/shadow/DateTimeFieldElement.cpp ('K') | « Source/core/html/shadow/DateTimeFieldElement.cpp ('k') | Source/core/html/shadow/DateTimeNumericFieldElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/shadow/DateTimeNumericFieldElement.h

diff --git a/Source/core/html/shadow/DateTimeNumericFieldElement.h b/Source/core/html/shadow/DateTimeNumericFieldElement.h

index 9b96fb54e3b59dab2978aec680db63a951ba41fe..b3e9c26182e147372c9d5548d939284454e6a615 100644

--- a/Source/core/html/shadow/DateTimeNumericFieldElement.h

+++ b/Source/core/html/shadow/DateTimeNumericFieldElement.h

@@ -80,7 +80,7 @@ protected:

private:

// DateTimeFieldElement functions.

- virtual void didBlur() OVERRIDE FINAL;

+ virtual void setFocus(bool) OVERRIDE FINAL;

tkent 2014/03/31 04:17:08 The above comment says setFocus(bool) is a member

Habib Virji 2014/03/31 09:05:51 Done.

virtual void handleKeyboardEvent(KeyboardEvent*) OVERRIDE FINAL;

virtual float maximumWidth(const Font&) OVERRIDE;

virtual void stepDown() OVERRIDE FINAL;