Source/core/html/shadow/DateTimeNumericFieldElement.h - Issue 191293011: Value set in onblur should not keep element in focus

Side by Side Diff: Source/core/html/shadow/DateTimeNumericFieldElement.h

Issue 191293011: Value set in onblur should not keep element in focus (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: SetFocus handler implementation for DateTimeFieldElement Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/html/shadow/DateTimeFieldElement.cpp ('K') | « Source/core/html/shadow/DateTimeFieldElement.cpp ('k') | Source/core/html/shadow/DateTimeNumericFieldElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 62 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73 virtual bool hasValue() const OVERRIDE FINAL;	73 virtual bool hasValue() const OVERRIDE FINAL;

74 void initialize(const AtomicString& pseudo, const String& axHelpText);	74 void initialize(const AtomicString& pseudo, const String& axHelpText);

75 int maximum() const;	75 int maximum() const;

76 virtual void setEmptyValue(EventBehavior = DispatchNoEvent) OVERRIDE FINAL;	76 virtual void setEmptyValue(EventBehavior = DispatchNoEvent) OVERRIDE FINAL;

77 virtual void setValueAsInteger(int, EventBehavior = DispatchNoEvent) OVERRID E;	77 virtual void setValueAsInteger(int, EventBehavior = DispatchNoEvent) OVERRID E;

78 virtual int valueAsInteger() const OVERRIDE FINAL;	78 virtual int valueAsInteger() const OVERRIDE FINAL;

79 virtual String visibleValue() const OVERRIDE FINAL;	79 virtual String visibleValue() const OVERRIDE FINAL;

80	80

81 private:	81 private:

82 // DateTimeFieldElement functions.	82 // DateTimeFieldElement functions.

83 virtual void didBlur() OVERRIDE FINAL;	83 virtual void setFocus(bool) OVERRIDE FINAL;
	tkent 2014/03/31 04:17:08 The above comment says setFocus(bool) is a member The above comment says setFocus(bool) is a member function of DateTimeFieldElement. But it's not. Please make a new section below "virtual String value()" like: virtual String value() const OVERRIDE FINAL; // Node functions. virtual void setFocus(bool) OVERRIDE FINAL; Habib Virji 2014/03/31 09:05:51 Done. Show quoted text On 2014/03/31 04:17:08, tkent wrote: > The above comment says setFocus(bool) is a member function of > DateTimeFieldElement. But it's not. Please make a new section below "virtual > String value()" like: > > virtual String value() const OVERRIDE FINAL; > > // Node functions. > virtual void setFocus(bool) OVERRIDE FINAL; > Done.
84 virtual void handleKeyboardEvent(KeyboardEvent*) OVERRIDE FINAL;	84 virtual void handleKeyboardEvent(KeyboardEvent*) OVERRIDE FINAL;

85 virtual float maximumWidth(const Font&) OVERRIDE;	85 virtual float maximumWidth(const Font&) OVERRIDE;

86 virtual void stepDown() OVERRIDE FINAL;	86 virtual void stepDown() OVERRIDE FINAL;

87 virtual void stepUp() OVERRIDE FINAL;	87 virtual void stepUp() OVERRIDE FINAL;

88 virtual String value() const OVERRIDE FINAL;	88 virtual String value() const OVERRIDE FINAL;

89	89

90 String formatValue(int) const;	90 String formatValue(int) const;

91 int roundUp(int) const;	91 int roundUp(int) const;

92 int roundDown(int) const;	92 int roundDown(int) const;

93 int typeAheadValue() const;	93 int typeAheadValue() const;

94	94

95 const String m_placeholder;	95 const String m_placeholder;

96 const Range m_range;	96 const Range m_range;

97 const Range m_hardLimits;	97 const Range m_hardLimits;

98 const Step m_step;	98 const Step m_step;

99 int m_value;	99 int m_value;

100 bool m_hasValue;	100 bool m_hasValue;

101 mutable StringBuilder m_typeAheadBuffer;	101 mutable StringBuilder m_typeAheadBuffer;

102 };	102 };

103	103

104 } // namespace WebCore	104 } // namespace WebCore

105	105

106 #endif	106 #endif

107 #endif	107 #endif

OLD	NEW