Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: third_party/WebKit/Source/core/paint/ImagePainter.cpp

Issue 1912863002: Fix image map focus ring painting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/ImagePainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/ImagePainter.cpp b/third_party/WebKit/Source/core/paint/ImagePainter.cpp
index 533896eb420a0281b965910046eadbbdc073f102..4cad5cbc457c74764fbcd8ceaf1a48da25a64ce1 100644
--- a/third_party/WebKit/Source/core/paint/ImagePainter.cpp
+++ b/third_party/WebKit/Source/core/paint/ImagePainter.cpp
@@ -33,8 +33,6 @@ void ImagePainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paintOff
void ImagePainter::paintAreaElementFocusRing(const PaintInfo& paintInfo, const LayoutPoint& paintOffset)
{
- // TODO(wangxianzhu): In other places, we just paint focus ring if outline style is auto.
- // We should also do that here to keep consistency.
Document& document = m_layoutImage.document();
if (paintInfo.isPrinting() || !document.frame()->selection().isFocusedAndActive())
@@ -51,26 +49,35 @@ void ImagePainter::paintAreaElementFocusRing(const PaintInfo& paintInfo, const L
// Even if the theme handles focus ring drawing for entire elements, it won't do it for
// an area within an image, so we don't call LayoutTheme::themeDrawsFocusRing here.
- Path path = areaElement.computePath(&m_layoutImage);
- if (path.isEmpty())
- return;
-
const ComputedStyle& areaElementStyle = *areaElement.ensureComputedStyle();
int outlineWidth = areaElementStyle.outlineWidth();
if (!outlineWidth)
return;
+ Path path = areaElement.getPath();
+ if (path.isEmpty())
+ return;
+
+ AffineTransform zoomTransform;
+ zoomTransform.scale(m_layoutImage.styleRef().effectiveZoom());
+ path.transform(zoomTransform);
+
+ LayoutPoint adjustedPaintOffset = paintOffset;
+ adjustedPaintOffset.moveBy(m_layoutImage.location());
+ path.translate(FloatSize(adjustedPaintOffset.x(), adjustedPaintOffset.y()));
+
if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, m_layoutImage, paintInfo.phase))
return;
- IntRect focusRect = m_layoutImage.absoluteContentBox();
+ LayoutRect focusRect = m_layoutImage.contentBoxRect();
+ focusRect.moveBy(adjustedPaintOffset);
LayoutObjectDrawingRecorder drawingRecorder(paintInfo.context, m_layoutImage, paintInfo.phase, focusRect);
// FIXME: Clip path instead of context when Skia pathops is ready.
// https://crbug.com/251206
paintInfo.context.save();
- paintInfo.context.clip(focusRect);
+ paintInfo.context.clip(pixelSnappedIntRect(focusRect));
paintInfo.context.drawFocusRing(path, outlineWidth,
areaElementStyle.outlineOffset(),
m_layoutImage.resolveColor(areaElementStyle, CSSPropertyOutlineColor));

Powered by Google App Engine
This is Rietveld 408576698