third_party/WebKit/Source/core/page/SpatialNavigation.cpp - Issue 1912863002: Fix image map focus ring painting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/SpatialNavigation.cpp

Issue 1912863002: Fix image map focus ring painting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/images/imagemap-focus-ring-in-positioned-container.html ('K') | « third_party/WebKit/Source/core/layout/LayoutImage.cpp ('k') | third_party/WebKit/Source/core/paint/ImagePainter.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/SpatialNavigation.cpp

diff --git a/third_party/WebKit/Source/core/page/SpatialNavigation.cpp b/third_party/WebKit/Source/core/page/SpatialNavigation.cpp

index a3efe2d1a628f033eee3d917760e85623b07e8b3..5fe617404adb66d320fb3c2aa56c2fee113d8ffc 100644

--- a/third_party/WebKit/Source/core/page/SpatialNavigation.cpp

+++ b/third_party/WebKit/Source/core/page/SpatialNavigation.cpp

@@ -628,7 +628,7 @@ LayoutRect virtualRectForAreaElementAndDirection(HTMLAreaElement& area, WebFocus

ASSERT(area.imageElement());

// Area elements tend to overlap more than other focusable elements. We flatten the rect of the area elements

// to minimize the effect of overlapping areas.

- LayoutRect rect = virtualRectForDirection(type, rectToAbsoluteCoordinates(area.document().frame(), area.computeRect(area.imageElement()->layoutObject())), LayoutUnit(1));

+ LayoutRect rect = virtualRectForDirection(type, rectToAbsoluteCoordinates(area.document().frame(), area.computeAbsoluteRect()), LayoutUnit(1));

return rect;

}