Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1912843002: Convert //components/sessions from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //components/sessions from scoped_ptr to std::unique_ptr BUG=554298 R=skuhne@chromium.org Committed: https://crrev.com/c51ac9e88916cb09ed5f0c4ea7d00d835f4223c7 Cr-Commit-Position: refs/heads/master@{#389020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -181 lines) Patch
M components/sessions/content/content_live_tab.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/sessions/content/content_live_tab.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/sessions/content/content_platform_specific_tab_data.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/content/content_platform_specific_tab_data.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/sessions/content/content_serialized_navigation_builder.h View 2 chunks +5 lines, -5 lines 0 comments Download
M components/sessions/content/content_serialized_navigation_builder.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/sessions/content/content_serialized_navigation_builder_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M components/sessions/core/base_session_service.h View 3 chunks +5 lines, -4 lines 0 comments Download
M components/sessions/core/base_session_service.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M components/sessions/core/base_session_service_commands.h View 2 chunks +12 lines, -11 lines 0 comments Download
M components/sessions/core/base_session_service_commands.cc View 8 chunks +16 lines, -12 lines 0 comments Download
M components/sessions/core/base_session_service_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sessions/core/in_memory_tab_restore_service.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/sessions/core/in_memory_tab_restore_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/live_tab.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/live_tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/persistent_tab_restore_service.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/sessions/core/persistent_tab_restore_service.cc View 8 chunks +17 lines, -16 lines 0 comments Download
M components/sessions/core/serialized_navigation_entry.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/serialized_navigation_entry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/session_backend.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sessions/core/session_backend.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M components/sessions/core/session_service_commands.h View 2 chunks +31 lines, -36 lines 0 comments Download
M components/sessions/core/session_service_commands.cc View 10 chunks +43 lines, -42 lines 0 comments Download
M components/sessions/core/session_types.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/tab_restore_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sessions/core/tab_restore_service_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/sessions/core/tab_restore_service_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sessions/ios/ios_serialized_navigation_builder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sessions/ios/ios_serialized_navigation_builder.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sessions/ios/ios_serialized_navigation_builder_unittest.mm View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
4 years, 8 months ago (2016-04-21 21:34:54 UTC) #1
Mr4D (OOO till 08-26)
lgtm
4 years, 8 months ago (2016-04-22 02:36:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912843002/1
4 years, 8 months ago (2016-04-22 03:13:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 04:06:03 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:44:07 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c51ac9e88916cb09ed5f0c4ea7d00d835f4223c7
Cr-Commit-Position: refs/heads/master@{#389020}

Powered by Google App Engine
This is Rietveld 408576698