components/sessions/core/tab_restore_service_helper.cc - Issue 1912843002: Convert //components/sessions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sessions/core/tab_restore_service_helper.cc

Issue 1912843002: Convert //components/sessions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sessions/core/tab_restore_service_client.h ('k') | components/sessions/ios/ios_serialized_navigation_builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sessions/core/tab_restore_service_helper.cc

diff --git a/components/sessions/core/tab_restore_service_helper.cc b/components/sessions/core/tab_restore_service_helper.cc

index 4ba55f96c0c5d96198e277c41740b1dfe6e2217f..f89946f240ceed4f638e8ed935dd9a1079c0764a 100644

--- a/components/sessions/core/tab_restore_service_helper.cc

+++ b/components/sessions/core/tab_restore_service_helper.cc

@@ -74,7 +74,7 @@ void TabRestoreServiceHelper::CreateHistoricalTab(LiveTab* live_tab,

if (closing_contexts_.find(context) != closing_contexts_.end())

return;

- scoped_ptr<Tab> local_tab(new Tab());

+ std::unique_ptr<Tab> local_tab(new Tab());

PopulateTab(local_tab.get(), index, context, live_tab);

if (local_tab->navigations.empty())

return;

@@ -85,7 +85,7 @@ void TabRestoreServiceHelper::CreateHistoricalTab(LiveTab* live_tab,

void TabRestoreServiceHelper::BrowserClosing(LiveTabContext* context) {

closing_contexts_.insert(context);

- scoped_ptr<Window> window(new Window());

+ std::unique_ptr<Window> window(new Window());

window->selected_tab_index = context->GetSelectedIndex();

window->timestamp = TimeNow();

window->app_name = context->GetAppName();