Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: src/builtins.cc

Issue 1912633002: [ic] Split LoadIC into LoadGlobalIC and LoadIC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/ast/ast.cc ('K') | « src/builtins.h ('k') | src/code-factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins.cc
diff --git a/src/builtins.cc b/src/builtins.cc
index 4a5ae9b60c298b245bb27a64d3376f49abe76e38..395321d74436f6cbb82f5b35d8ce043d0f9460e1 100644
--- a/src/builtins.cc
+++ b/src/builtins.cc
@@ -5337,6 +5337,18 @@ void Generate_LoadIC_Miss(CodeStubAssembler* assembler) {
slot, vector);
}
+void Generate_LoadGlobalIC_Miss(CodeStubAssembler* assembler) {
+ typedef compiler::Node Node;
+
+ Node* name = assembler->Parameter(0);
+ Node* slot = assembler->Parameter(1);
+ Node* vector = assembler->Parameter(2);
+ Node* context = assembler->Parameter(3);
+
+ assembler->TailCallRuntime(Runtime::kLoadGlobalIC_Miss, context, name, slot,
+ vector);
+}
+
void Generate_LoadIC_Normal(MacroAssembler* masm) {
LoadIC::GenerateNormal(masm);
}
@@ -5357,6 +5369,17 @@ void Generate_LoadIC_Slow(CodeStubAssembler* assembler) {
assembler->TailCallRuntime(Runtime::kGetProperty, context, receiver, name);
}
+void Generate_LoadGlobalIC_Slow(CodeStubAssembler* assembler) {
+ typedef compiler::Node Node;
+
+ Node* name = assembler->Parameter(0);
+ // Node* slot = assembler->Parameter(1);
+ // Node* vector = assembler->Parameter(2);
+ Node* context = assembler->Parameter(3);
+
+ assembler->TailCallRuntime(Runtime::kGetGlobal, context, name);
+}
+
void Generate_KeyedLoadIC_Slow(MacroAssembler* masm) {
KeyedLoadIC::GenerateRuntimeGetProperty(masm);
}
« src/ast/ast.cc ('K') | « src/builtins.h ('k') | src/code-factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698