[ic] Split LoadIC into LoadGlobalIC and LoadIC.

src/ast/ast.cc

Index: src/ast/ast.cc
diff --git a/src/ast/ast.cc b/src/ast/ast.cc
index a943fdf05cafd437e75ce5ab1524365569d4227a..a8731ce02a972aff16a8e647ea803bebd74dc95f 100644
--- a/src/ast/ast.cc
+++ b/src/ast/ast.cc
@@ -120,17 +120,17 @@ void VariableProxy::AssignFeedbackVectorSlots(Isolate* isolate,
   if (UsesVariableFeedbackSlot()) {
     // VariableProxies that point to the same Variable within a function can
     // make their loads from the same IC slot.
-    if (var()->IsUnallocated()) {
+    if (var()->IsUnallocated() || var()->mode() == DYNAMIC_GLOBAL) {
       ZoneHashMap::Entry* entry = cache->Get(var());
       if (entry != NULL) {
         variable_feedback_slot_ = FeedbackVectorSlot(
             static_cast<int>(reinterpret_cast<intptr_t>(entry->value)));
         return;
       }
-    }
-    variable_feedback_slot_ = spec->AddLoadICSlot();
-    if (var()->IsUnallocated()) {
+      variable_feedback_slot_ = spec->AddLoadGlobalICSlot();
       cache->Put(var(), variable_feedback_slot_);
+    } else {
+      variable_feedback_slot_ = spec->AddLoadICSlot();

[mvstanton, 2016/06/13 14:06:41]

This is confusing, because it looks like it's saying "If I don't use a
VariableFeedbackSlot...then allocate a VariableFeedbackSlot."

Can the predicate UsesVariableFeedbackSlot() be redefined more usefully?

     }
   }
 }