Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1912553002: Fix 'typeof null' canonicalization in crankshaft (Closed)

Created:
4 years, 8 months ago by Toon Verwaest
Modified:
4 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix 'typeof null' canonicalization in crankshaft BUG= Committed: https://crrev.com/7dfb5beeec8821521beeb2b8eac36707a663064c Cr-Commit-Position: refs/heads/master@{#35699}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M src/crankshaft/hydrogen-instructions.cc View 1 2 chunks +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-opt-typeof-null.js View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Toon Verwaest
ptal
4 years, 8 months ago (2016-04-21 09:27:12 UTC) #2
Jakob Kummerow
LGTM with comment. https://codereview.chromium.org/1912553002/diff/1/src/crankshaft/hydrogen-instructions.cc File src/crankshaft/hydrogen-instructions.cc (right): https://codereview.chromium.org/1912553002/diff/1/src/crankshaft/hydrogen-instructions.cc#newcode1219 src/crankshaft/hydrogen-instructions.cc:1219: if (unique.IsKnownGlobal(heap->null_value())) { This is dead ...
4 years, 8 months ago (2016-04-21 09:30:56 UTC) #3
Toon Verwaest
addressed comment
4 years, 8 months ago (2016-04-21 10:41:45 UTC) #4
Jakob Kummerow
lgtm
4 years, 8 months ago (2016-04-21 10:54:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912553002/20001
4 years, 8 months ago (2016-04-21 10:56:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 11:23:42 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:36 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7dfb5beeec8821521beeb2b8eac36707a663064c
Cr-Commit-Position: refs/heads/master@{#35699}

Powered by Google App Engine
This is Rietveld 408576698