Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 1912483003: Expand the footer in the material design Clear Browsing Data dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
index d278cfd618a9560dc42f3c65b54ea94c5970029b..3828e7cfdc77e6293cc6ed008dfb1899537604fb 100644
--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
@@ -299,6 +299,20 @@ void AddClearBrowsingDataStrings(content::WebUIDataSource* html_source) {
{"warnAboutNonClearedData", IDS_SETTINGS_CLEAR_DATA_SOME_STUFF_REMAINS},
{"clearsSyncedData", IDS_SETTINGS_CLEAR_DATA_CLEARS_SYNCED_DATA},
};
+
+ static const char kClearBrowsingDataLearnMoreUrl[] =
+ "https://support.google.com/chrome/?p=settings_clear_browsing_data";
+ static const char kWebHistoryUrlInFooter[] =
+ "https://history.google.com/history/?utm_source=chrome_cbd";
dschuyler 2016/04/27 23:10:41 If there's any chance this might need to be locali
msramek 2016/04/28 14:34:18 Done. I put them there and marked them as non-tran
+
+ html_source->AddString("clearBrowsingDataLearnMoreUrl",
+ kClearBrowsingDataLearnMoreUrl);
+ html_source->AddString(
+ "otherFormsOfBrowsingHistory",
+ l10n_util::GetStringFUTF16(
+ IDS_CLEAR_BROWSING_DATA_HISTORY_FOOTER,
+ base::ASCIIToUTF16(kWebHistoryUrlInFooter)));
+
AddLocalizedStringsBulk(html_source, localized_strings,
arraysize(localized_strings));
}

Powered by Google App Engine
This is Rietveld 408576698