Expand the footer in the material design Clear Browsing Data dialog.

chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 281 matching lines @@
       {"clearDeauthorizeContentLicenses",
        IDS_SETTINGS_DEAUTHORIZE_CONTENT_LICENSES},
       {"clearDataHour", IDS_SETTINGS_CLEAR_DATA_HOUR},
       {"clearDataDay", IDS_SETTINGS_CLEAR_DATA_DAY},
       {"clearDataWeek", IDS_SETTINGS_CLEAR_DATA_WEEK},
       {"clearData4Weeks", IDS_SETTINGS_CLEAR_DATA_4WEEKS},
       {"clearDataEverything", IDS_SETTINGS_CLEAR_DATA_EVERYTHING},
       {"warnAboutNonClearedData", IDS_SETTINGS_CLEAR_DATA_SOME_STUFF_REMAINS},
       {"clearsSyncedData", IDS_SETTINGS_CLEAR_DATA_CLEARS_SYNCED_DATA},
   };
+
+  static const char kClearBrowsingDataLearnMoreUrl[] =
+      "https://support.google.com/chrome/?p=settings_clear_browsing_data";
+  static const char kWebHistoryUrlInFooter[] =
+      "https://history.google.com/history/?utm_source=chrome_cbd";

[dschuyler, 2016/04/27 23:10:41]

If there's any chance this might need to be localized, consider adding
them to chrome/app/resources/locale_settings.grd

If not, consider adding them to chrome/common/url_constants.cc

[msramek, 2016/04/28 14:34:18]

Done. I put them there and marked them as non-translateable for now. I can see
that some strings explicitly specify "hl=[GRITLANGCODE]", but most just rely on
the website redirecting to the correct localized version. So I'll leave this as
is for now.

+
+  html_source->AddString("clearBrowsingDataLearnMoreUrl",
+                         kClearBrowsingDataLearnMoreUrl);
+  html_source->AddString(
+      "otherFormsOfBrowsingHistory",
+      l10n_util::GetStringFUTF16(
+          IDS_CLEAR_BROWSING_DATA_HISTORY_FOOTER,
+          base::ASCIIToUTF16(kWebHistoryUrlInFooter)));
+
   AddLocalizedStringsBulk(html_source, localized_strings,
                           arraysize(localized_strings));
 }
 
 void AddCloudPrintStrings(content::WebUIDataSource* html_source) {
   LocalizedString localized_strings[] = {
       {"googleCloudPrint", IDS_SETTINGS_GOOGLE_CLOUD_PRINT},
   };
   AddLocalizedStringsBulk(html_source, localized_strings,
                           arraysize(localized_strings));
@@ skipping 646 matching lines @@
 #endif
   AddUsersStrings(html_source);
   AddWebContentStrings(html_source);
 
   policy_indicator::AddLocalizedStrings(html_source);
 
   html_source->SetJsonPath(kLocalizedStringsFile);
 }
 
 }  // namespace settings