Expand the footer in the material design Clear Browsing Data dialog.

Expand the footer in the material design Clear Browsing Data dialog.

Design doc:
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/

The footer in Clear Browsing Data dialog now contains three sentences.
1. Static sentence informing the user that all browsing data can be cleared.
2. A sentence about synced data, only shown when Sync is active.
3. A sentence about other forms of browsing history, only shown when
   browsing_data_ui::ShouldShowNoticeAboutOtherFormsOfBrowsingHistory is true.

ClearBrowsingDataHandler listens to ProfileSyncService and adjust sentence #2
immediately. The condition for #3 is only checked at initialization.

As per mocks, we split the footer into two paragraphs - one containing
sentences #1 and #2 annotated with an (i) icon, and one for sentence #3
annotated with a "G" icon.

BUG=595332
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3a81a13676c458976f3125cc68d937ea020f7327
Cr-Commit-Position: refs/heads/master@{#390928}

[msramek, 2016-04-21 14:02:32]

msramek@chromium.org changed reviewers:
+ dschuyler@chromium.org

[msramek, 2016-04-21 14:02:33]

Hi Dave,

can you please have a look?

This is for feature parity with https://codereview.chromium.org/1813023002/ that
was recently added to WebUI.

Thanks,
Martin

[msramek, 2016-04-26 07:15:02]

Friendly ping!

[dschuyler, 2016-04-26 16:58:39]

https://codereview.chromium.org/1912483003/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.css
(right):

https://codereview.chromium.org/1912483003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.css:4:

Please move the contents of this file to a style-module or
the .html file. (We are no longer using separate .css imports).

https://codereview.chromium.org/1912483003/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
(right):

https://codereview.chromium.org/1912483003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html:13:
<link rel="import" type="css" href="clear_browsing_data_dialog.css">
This old style if importing the css is deprecated.  Please create
a style-module (I'm happy to explain that more) or inline the css
in the <style> below.

[dschuyler, 2016-04-26 17:29:49]

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.css
(right):

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.css:42:
approximately at the ascender line of the font. */
Does this make the clickable area of the icon smaller?
If it does, consider shifting the icon with 'top:'.

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
(right):

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html:69:
<div id="googleFooter" class="clear-browsing-data-footer">
nit: consider using 'settings' as a prefix rather than 'google'
(unless this applies more broadly that settings).

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html:78:
<span i18n-content="warnAboutNonClearedData"></span>
Please change the i18n-content to $i18n{}, like line 77 above.

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html:80:
i18n-values="href:clearBrowsingDataLearnMoreUrl"
i18n-values="foo:bar" can be re-written as 
foo="$i18n{bar}"
If bar may contain html, you may need 
foo="$18nRaw{bar}"
so that the html is not escaped.

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
(right):

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js:60:
attached: function() {
Can this be started earlier from ready() rather
than waiting for attached()?

https://codereview.chromium.org/1912483003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/privacy_page_test.js (right):

https://codereview.chromium.org/1912483003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/privacy_page_test.js:30:
settings.TestBrowserProxy.call(this, ['clearBrowsingData']);
I think this should have 'initializeFooter' added to this list.

[dschuyler, 2016-04-26 18:47:03]

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
(right):

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc:40:
sync_service_->AddObserver(this);
Rather than adding an observer in the constructor,
please add OnJavascriptAllowed() and OnJavascriptDisallowed()
calls to add and remove observers.

An example is here:
https://codereview.chromium.org/1896463003/diff/120001/chrome/browser/ui/webu...

Further info is here:
https://docs.google.com/document/d/1z1diKvwgMmn4YFzlW1kss0yHmo8yy68TN_FUhUzRz...

[msramek, 2016-04-27 18:10:29]

Please have another look!

Since the change with OnJavascriptAllowed was landed after I wrote this CL, I
had to rebase first and address your comments in the next patch, so that it
would compile. Sorry if it's a bit messy.

https://codereview.chromium.org/1912483003/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.css
(right):

https://codereview.chromium.org/1912483003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.css:4:

On 2016/04/26 16:58:39, dschuyler wrote:
> Please move the contents of this file to a style-module or
> the .html file. (We are no longer using separate .css imports).

I see imports of CSS through <style include="settings-shared">, defined in
settings_shared_css.html. Is that a style-module?

Nevertheless, it seems that most .html files in settings/ do not create a custom
module, just inline. In my case, the CSS is not going to be used anywhere else,
so I'll also just inline.

https://codereview.chromium.org/1912483003/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
(right):

https://codereview.chromium.org/1912483003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html:13:
<link rel="import" type="css" href="clear_browsing_data_dialog.css">
On 2016/04/26 16:58:39, dschuyler wrote:
> This old style if importing the css is deprecated.  Please create
> a style-module (I'm happy to explain that more) or inline the css
> in the <style> below.

As explained in the other comment, I chose to inline the CSS. Happy to make a
style module if that's preferred, though.

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.css
(right):

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.css:42:
approximately at the ascender line of the font. */
On 2016/04/26 17:29:49, dschuyler wrote:
> Does this make the clickable area of the icon smaller?
> If it does, consider shifting the icon with 'top:'.

Padding counts towards the size of the object, so it should be larger, no?

Side question - the icon is not clickable. Should I use something else than
iron-icon in that case?

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
(right):

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html:69:
<div id="googleFooter" class="clear-browsing-data-footer">
On 2016/04/26 17:29:49, dschuyler wrote:
> nit: consider using 'settings' as a prefix rather than 'google'
> (unless this applies more broadly that settings).

This is the same nomenclature that we used on Android, see here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/android/jav...

The idea is that first paragraphs contains information specific to Google
account users, and is decorated with the Google logo. The other paragraph
contains more general information, and it's called "generalFooter".

"settings" doesn't capture this difference. Maybe we could rename it to mention
that this paragraph talks about other forms of browsing history, but my personal
preference would be to leave consistent with Android.

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html:78:
<span i18n-content="warnAboutNonClearedData"></span>
On 2016/04/26 17:29:49, dschuyler wrote:
> Please change the i18n-content to $i18n{}, like line 77 above.

Done. Sorry, missed this one.

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html:80:
i18n-values="href:clearBrowsingDataLearnMoreUrl"
On 2016/04/26 17:29:49, dschuyler wrote:
> i18n-values="foo:bar" can be re-written as 
> foo="$i18n{bar}"
> If bar may contain html, you may need 
> foo="$18nRaw{bar}"
> so that the html is not escaped. 

Done. Here, and with .innerHTML above.

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
(right):

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js:60:
attached: function() {
On 2016/04/26 17:29:49, dschuyler wrote:
> Can this be started earlier from ready() rather
> than waiting for attached()?

Done. Yes, thanks for pointing this out!

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
(right):

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc:40:
sync_service_->AddObserver(this);
On 2016/04/26 18:47:03, dschuyler wrote:
> Rather than adding an observer in the constructor,
> please add OnJavascriptAllowed() and OnJavascriptDisallowed()
> calls to add and remove observers.
> 
> An example is here:
>
https://codereview.chromium.org/1896463003/diff/120001/chrome/browser/ui/webu...
> 
> Further info is here:
>
https://docs.google.com/document/d/1z1diKvwgMmn4YFzlW1kss0yHmo8yy68TN_FUhUzRz...

Done. We're ready for JavaScript callbacks updating the footer after the footer
was first initialized, so I put AllowJavascript() there.

https://codereview.chromium.org/1912483003/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/privacy_page_test.js (right):

https://codereview.chromium.org/1912483003/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/privacy_page_test.js:30:
settings.TestBrowserProxy.call(this, ['clearBrowsingData']);
On 2016/04/26 17:29:49, dschuyler wrote:
> I think this should have 'initializeFooter' added to this list.

Done. Also fixed the missing this.methodCalled().

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
(right):

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html:16:
max-width: 600px;
I narrowed this even more, from 700px to 600px, as I realized that for
non-syncing users the "Learn more" link would be the only thing on the second
line of that paragraph. The agreement that we had with maxwalker@ was to
optimize for the default English text to be nicely aligned.

[dschuyler, 2016-04-27 23:10:41]

Sorry for not catching these the first time around, 
but I found a few more things to comment on.

https://codereview.chromium.org/1912483003/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.css
(right):

https://codereview.chromium.org/1912483003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.css:4:

On 2016/04/27 18:10:28, msramek wrote:
> On 2016/04/26 16:58:39, dschuyler wrote:
> > Please move the contents of this file to a style-module or
> > the .html file. (We are no longer using separate .css imports).
> 
> I see imports of CSS through <style include="settings-shared">, defined in
> settings_shared_css.html. Is that a style-module?

Yeah.  A style-module is a dom-module that just has a style section.

> 
> Nevertheless, it seems that most .html files in settings/ do not create a
custom
> module, just inline. In my case, the CSS is not going to be used anywhere
else,
> so I'll also just inline.

Perfect.  Yeah, if the style is used across settings then it should be in that 
settings-shared module, while if it's used in only one place then inlining is
the right thing.

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.css
(right):

https://codereview.chromium.org/1912483003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.css:42:
approximately at the ascender line of the font. */
On 2016/04/27 18:10:29, msramek wrote:
> On 2016/04/26 17:29:49, dschuyler wrote:
> > Does this make the clickable area of the icon smaller?
> > If it does, consider shifting the icon with 'top:'.
> 
> Padding counts towards the size of the object, so it should be larger, no?
> 
> Side question - the icon is not clickable. Should I use something else than
> iron-icon in that case?

My mistake.  If it's not clickable then this is fine as is.

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
(right):

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html:32:
width: 18px;
Optional: Consider making the icons 20px by 20px to match with the
settings UX design.  The 18px size is ok if that's called for 
specifically by UI.

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html:42:
width: 16px;
(same comment about 20 by 20 icons. 16px is ok if that's
called for or better for specific reasons)

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
(right):

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js:59:
this.browserProxy_.initializeFooter();
nit: consider dropping Footer from the name and removing 
the comment.  imo, this.browserProxy_.initialize(); relays a
reasonable picture of what that code is doing.

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js:76:
* Updates the footer. Shows only those sentences that are relevant to this
nit: "Update the footer to show only..."

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:306:
"https://history.google.com/history/?utm_source=chrome_cbd";
If there's any chance this might need to be localized, consider adding
them to chrome/app/resources/locale_settings.grd

If not, consider adding them to chrome/common/url_constants.cc

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
(right):

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc:53:
base::Bind(&ClearBrowsingDataHandler::InitializeFooter,
nit: add Handler prefix to handlers. e.g. HandleInitializeFooter
Also consider dropping Footer suffix.

[msramek, 2016-04-28 14:06:44]

Patchset #5 (id:80001) has been deleted

[msramek, 2016-04-28 14:34:18]

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
(right):

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html:32:
width: 18px;
On 2016/04/27 23:10:40, dschuyler wrote:
> Optional: Consider making the icons 20px by 20px to match with the
> settings UX design.  The 18px size is ok if that's called for 
> specifically by UI.

This is an official icon that has a size 18x18 (which is in itself weird,
because normally those are 16x16 or 24x24). Given that it's an SVG, we could
stretch it, but it might look blurry (misaligned with the pixel grid). But I did
give it 1px padding, so that the icon is centered within a 20x20 square.
Similarly, 2px padding for the 16x16 icon below.

I removed the padding-top defined further below. For the 16x16 icon it's a
no-op, for the 18x18 one it still looks good.

We had another pass at this with maxwalker@ and decided to align the icons with
the checkboxes above and the footer text with the checkbox descriptions. I
adjusted a few more margins and paddings to match that. But this CL is primarily
intended to land the functional parts, I'm of course happy to adjust the CSS
later if it turns out not to be a correct style.

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html:42:
width: 16px;
On 2016/04/27 23:10:40, dschuyler wrote:
> (same comment about 20 by 20 icons. 16px is ok if that's
> called for or better for specific reasons)

Same as in the above comment; this is an official icon, so we don't want to
scale it by a nonstandard coefficient.

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
(right):

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js:59:
this.browserProxy_.initializeFooter();
On 2016/04/27 23:10:41, dschuyler wrote:
> nit: consider dropping Footer from the name and removing 
> the comment.  imo, this.browserProxy_.initialize(); relays a
> reasonable picture of what that code is doing.

Done. Agreed, now that we also call AllowJavascript() in the handler, this
method does more than just initialize the footer.

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js:76:
* Updates the footer. Shows only those sentences that are relevant to this
On 2016/04/27 23:10:41, dschuyler wrote:
> nit: "Update the footer to show only..."

Done.

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:306:
"https://history.google.com/history/?utm_source=chrome_cbd";
On 2016/04/27 23:10:41, dschuyler wrote:
> If there's any chance this might need to be localized, consider adding
> them to chrome/app/resources/locale_settings.grd
> 
> If not, consider adding them to chrome/common/url_constants.cc

Done. I put them there and marked them as non-translateable for now. I can see
that some strings explicitly specify "hl=[GRITLANGCODE]", but most just rely on
the website redirecting to the correct localized version. So I'll leave this as
is for now.

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
(right):

https://codereview.chromium.org/1912483003/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc:53:
base::Bind(&ClearBrowsingDataHandler::InitializeFooter,
On 2016/04/27 23:10:41, dschuyler wrote:
> nit: add Handler prefix to handlers. e.g. HandleInitializeFooter
> Also consider dropping Footer suffix.

Done.

[dschuyler, 2016-04-29 21:07:17]

LGTM with a name change request.

https://codereview.chromium.org/1912483003/diff/100001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
(right):

https://codereview.chromium.org/1912483003/diff/100001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc:52:
"initialize",
Sorry, suggesting 'initialize' wasn't a good choice
on my part. These labels are shared across settings.
So this 'initialize' means that other settings sections
cannot have a message that is also called 'initialize'.
Please add something to 'initialize' to make it distinct
to clear browsing data. Though still not 'initializeFooter'
:)

[msramek, 2016-05-02 12:02:59]

Description was changed from

==========
Expand the footer in the material design Clear Browsing Data dialog.

Design doc:
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/

The footer in Clear Browsing Data dialog now contains three sentences.
1. Static sentence informing the user that all browsing data can be cleared.
2. A sentence about synced data, only shown when Sync is active.
3. A sentence about other forms of browsing history, only shown when
   browsing_data_ui::ShouldShowNoticeAboutOtherFormsOfBrowsingHistory is true.

ClearBrowsingDataHandler listens to ProfileSyncService and adjust sentence #2
immediately. The condition for #3 is only checked at initialization.

As per mocks, we split the footer into two paragraphs - one containing
sentences #1 and #2 annotated with an (i) icon, and one for sentence #3
annotated with a "G" icon.

BUG=595332
==========

to

==========
Expand the footer in the material design Clear Browsing Data dialog.

Design doc:
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/

The footer in Clear Browsing Data dialog now contains three sentences.
1. Static sentence informing the user that all browsing data can be cleared.
2. A sentence about synced data, only shown when Sync is active.
3. A sentence about other forms of browsing history, only shown when
   browsing_data_ui::ShouldShowNoticeAboutOtherFormsOfBrowsingHistory is true.

ClearBrowsingDataHandler listens to ProfileSyncService and adjust sentence #2
immediately. The condition for #3 is only checked at initialization.

As per mocks, we split the footer into two paragraphs - one containing
sentences #1 and #2 annotated with an (i) icon, and one for sentence #3
annotated with a "G" icon.

BUG=595332
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[msramek, 2016-05-02 13:08:09]

https://codereview.chromium.org/1912483003/diff/100001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
(right):

https://codereview.chromium.org/1912483003/diff/100001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc:52:
"initialize",
On 2016/04/29 21:07:17, dschuyler wrote:
> Sorry, suggesting 'initialize' wasn't a good choice
> on my part. These labels are shared across settings.
> So this 'initialize' means that other settings sections
> cannot have a message that is also called 'initialize'.
> Please add something to 'initialize' to make it distinct
> to clear browsing data. Though still not 'initializeFooter'
> :)

Done.

I think the only thing that isn't prone to collision is
"initializeClearBrowsingData", so let's use that (even though it's similar to
the other message name).

[msramek, 2016-05-02 13:08:55]

Thanks for the thorough review! :-)

[msramek, 2016-05-02 13:09:09]

The CQ bit was checked by msramek@chromium.org

[msramek, 2016-05-02 13:09:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/1912483003/#ps140001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-05-02 13:09:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912483003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1912483003/140001

[commit-bot: I haz the power, 2016-05-02 13:22:46]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2016-05-02 13:23:39]

Description was changed from

==========
Expand the footer in the material design Clear Browsing Data dialog.

Design doc:
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/

The footer in Clear Browsing Data dialog now contains three sentences.
1. Static sentence informing the user that all browsing data can be cleared.
2. A sentence about synced data, only shown when Sync is active.
3. A sentence about other forms of browsing history, only shown when
   browsing_data_ui::ShouldShowNoticeAboutOtherFormsOfBrowsingHistory is true.

ClearBrowsingDataHandler listens to ProfileSyncService and adjust sentence #2
immediately. The condition for #3 is only checked at initialization.

As per mocks, we split the footer into two paragraphs - one containing
sentences #1 and #2 annotated with an (i) icon, and one for sentence #3
annotated with a "G" icon.

BUG=595332
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Expand the footer in the material design Clear Browsing Data dialog.

Design doc:
https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/

The footer in Clear Browsing Data dialog now contains three sentences.
1. Static sentence informing the user that all browsing data can be cleared.
2. A sentence about synced data, only shown when Sync is active.
3. A sentence about other forms of browsing history, only shown when
   browsing_data_ui::ShouldShowNoticeAboutOtherFormsOfBrowsingHistory is true.

ClearBrowsingDataHandler listens to ProfileSyncService and adjust sentence #2
immediately. The condition for #3 is only checked at initialization.

As per mocks, we split the footer into two paragraphs - one containing
sentences #1 and #2 annotated with an (i) icon, and one for sentence #3
annotated with a "G" icon.

BUG=595332
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3a81a13676c458976f3125cc68d937ea020f7327
Cr-Commit-Position: refs/heads/master@{#390928}
==========

[commit-bot: I haz the power, 2016-05-02 13:23:40]

Patchset 7 (id:??) landed as
https://crrev.com/3a81a13676c458976f3125cc68d937ea020f7327
Cr-Commit-Position: refs/heads/master@{#390928}