tools/perf/benchmarks/page_cycler.py - Issue 1912443002: Reimplement basic PopularUrls page cycler in telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/page_cycler.py

Issue 1912443002: Reimplement basic PopularUrls page cycler in telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/page_cycler.py

diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py

index deaf9a49cb779f0b24e735a2575a545cec8dffea..d69e8c420ce759fcd0da454d74254788c7be4dd9 100644

--- a/tools/perf/benchmarks/page_cycler.py

+++ b/tools/perf/benchmarks/page_cycler.py

@@ -231,3 +231,12 @@ class PageCyclerBigJs(_PageCycler):

@classmethod

def Name(cls):

return 'page_cycler.big_js'

rnephew (Reviews Here) 2016/05/02 18:02:52 nit: 2 lines.

+@benchmark.Disabled('all')

+class PageCyclerPopularUrls(_PageCycler):

+ options = {'pageset_repeat': 1}

+ page_set = page_sets.PopularUrlsPageSet

+ @classmethod

+ def Name(cls):

+ return 'page_cycler.popular_urls'

« no previous file with comments | « no previous file | tools/perf/page_sets/data/popular_urls.json » ('j') | tools/perf/page_sets/key_mobile_sites.py » ('J')