Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2503)

Unified Diff: appengine/findit/handlers/build_failure.py

Issue 1912243003: [Findit] Add more tests to improve code coverage. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/findit/handlers/test/build_failure_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/handlers/build_failure.py
diff --git a/appengine/findit/handlers/build_failure.py b/appengine/findit/handlers/build_failure.py
index b69958b8e70a012387bfd3a1bb6f02feb25314ff..16245b68fc64e27ffe65911c5501500704b58260 100644
--- a/appengine/findit/handlers/build_failure.py
+++ b/appengine/findit/handlers/build_failure.py
@@ -294,7 +294,6 @@ class BuildFailure(BaseHandler):
'analysis_correct': analysis.correct,
'triage_history': _GetTriageHistory(analysis),
'show_triage_help_button': self._ShowTriageHelpButton(),
- 'status_message_map': result_status.STATUS_MESSAGE_MAP
}
@staticmethod
@@ -345,6 +344,7 @@ class BuildFailure(BaseHandler):
def _PrepareDataForTestFailures(self, analysis, build_info):
data = self._PrepareCommonDataForFailure(analysis)
+ data['status_message_map'] = result_status.STATUS_MESSAGE_MAP
organized_results = _GetOrganizedAnalysisResultBySuspectedCL(
analysis.result)
@@ -390,7 +390,7 @@ class BuildFailure(BaseHandler):
build_completed=build_completed, force=force,
queue_name=constants.WATERFALL_ANALYSIS_QUEUE)
- if analysis.failure_type == failure_type.COMPILE: # pragma: no branch
+ if analysis.failure_type == failure_type.COMPILE:
return {
'template': 'waterfall/compile_failure.html',
'data': self._PrepareDataForCompileFailure(analysis),
« no previous file with comments | « no previous file | appengine/findit/handlers/test/build_failure_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698