Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 1912173003: Allow adding story keys to values with existing tir labels (Closed)

Created:
4 years, 8 months ago by petrcermak
Modified:
4 years, 8 months ago
Reviewers:
eakuefner, nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, perezju
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Allow adding story keys to values with existing tir labels Rationale: This is necessary to allow reusing the same story set in both TBMv1 and TBMv2 benchmarks (e.g. https://codereview.chromium.org/1907343002/). BUG=chromium:581716 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/2f1e6ccff37c899c635e695ca8290925dc0bd429

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M telemetry/telemetry/internal/results/page_test_results.py View 1 chunk +6 lines, -6 lines 0 comments Download
M telemetry/telemetry/internal/results/page_test_results_unittest.py View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
petrcermak
PTAL. Thanks, Petr
4 years, 8 months ago (2016-04-22 17:08:32 UTC) #2
nednguyen
lgtm
4 years, 8 months ago (2016-04-23 13:17:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912173003/1
4 years, 8 months ago (2016-04-23 13:17:26 UTC) #5
nednguyen
On 2016/04/23 13:17:09, nednguyen wrote: > lgtm Sorry, I forgot about this case of tbm1 ...
4 years, 8 months ago (2016-04-23 13:18:07 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-23 13:32:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698