Index: telemetry/telemetry/internal/results/page_test_results_unittest.py |
diff --git a/telemetry/telemetry/internal/results/page_test_results_unittest.py b/telemetry/telemetry/internal/results/page_test_results_unittest.py |
index c929815fe5edb01d85ae59b6edd6b8cff6526aa9..efad8dba4b1f8c8d259d1a1d7f64a42a1a20aa05 100644 |
--- a/telemetry/telemetry/internal/results/page_test_results_unittest.py |
+++ b/telemetry/telemetry/internal/results/page_test_results_unittest.py |
@@ -107,6 +107,25 @@ class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest): |
self.assertEquals(v.grouping_keys['answer'], '42') |
self.assertEquals(v.tir_label, '42_bar') |
+ def testAddValueWithStoryGroupingKeysAndExistingTirLabel(self): |
+ results = page_test_results.PageTestResults() |
+ self.pages[0].grouping_keys['foo'] = 'bar' |
+ self.pages[0].grouping_keys['answer'] = '42' |
+ results.WillRunPage(self.pages[0]) |
+ results.AddValue(scalar.ScalarValue( |
+ self.pages[0], 'a', 'seconds', 3, |
+ improvement_direction=improvement_direction.UP, |
+ tir_label='existing_label')) |
+ results.DidRunPage(self.pages[0]) |
+ |
+ results.PrintSummary() |
+ |
+ values = results.FindPageSpecificValuesForPage(self.pages[0], 'a') |
+ v = values[0] |
+ self.assertEquals(v.grouping_keys['foo'], 'bar') |
+ self.assertEquals(v.grouping_keys['answer'], '42') |
+ self.assertEquals(v.tir_label, 'existing_label') |
+ |
def testAddValueWithDuplicateStoryGroupingKeyFails(self): |
results = page_test_results.PageTestResults() |
self.pages[0].grouping_keys['foo'] = 'bar' |