Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: telemetry/telemetry/internal/results/page_test_results_unittest.py

Issue 1912173003: Allow adding story keys to values with existing tir labels (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/internal/results/page_test_results.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/results/page_test_results_unittest.py
diff --git a/telemetry/telemetry/internal/results/page_test_results_unittest.py b/telemetry/telemetry/internal/results/page_test_results_unittest.py
index c929815fe5edb01d85ae59b6edd6b8cff6526aa9..efad8dba4b1f8c8d259d1a1d7f64a42a1a20aa05 100644
--- a/telemetry/telemetry/internal/results/page_test_results_unittest.py
+++ b/telemetry/telemetry/internal/results/page_test_results_unittest.py
@@ -107,6 +107,25 @@ class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):
self.assertEquals(v.grouping_keys['answer'], '42')
self.assertEquals(v.tir_label, '42_bar')
+ def testAddValueWithStoryGroupingKeysAndExistingTirLabel(self):
+ results = page_test_results.PageTestResults()
+ self.pages[0].grouping_keys['foo'] = 'bar'
+ self.pages[0].grouping_keys['answer'] = '42'
+ results.WillRunPage(self.pages[0])
+ results.AddValue(scalar.ScalarValue(
+ self.pages[0], 'a', 'seconds', 3,
+ improvement_direction=improvement_direction.UP,
+ tir_label='existing_label'))
+ results.DidRunPage(self.pages[0])
+
+ results.PrintSummary()
+
+ values = results.FindPageSpecificValuesForPage(self.pages[0], 'a')
+ v = values[0]
+ self.assertEquals(v.grouping_keys['foo'], 'bar')
+ self.assertEquals(v.grouping_keys['answer'], '42')
+ self.assertEquals(v.tir_label, 'existing_label')
+
def testAddValueWithDuplicateStoryGroupingKeyFails(self):
results = page_test_results.PageTestResults()
self.pages[0].grouping_keys['foo'] = 'bar'
« no previous file with comments | « telemetry/telemetry/internal/results/page_test_results.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698