Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1912153002: Articulate the cancel behavior in WebMouseWheelEvent. (Closed)

Created:
4 years, 8 months ago by dtapuska
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Articulate the cancel behavior in WebMouseWheelEvent. Add a DispatchType to mouse wheel events; set the cancelable flag based on the dispatch type. This change is similar to the one done for touch events see https://codereview.chromium.org/1888163003/. BUG=601661 Review URL: https://codereview.chromium.org/1894363004 Cr-Commit-Position: refs/heads/master@{#388643} (cherry picked from commit 8050a57a2e31012caa7d0521a9be661491f8ef3d) Committed: https://chromium.googlesource.com/chromium/src/+/0da211979aa69008d06680383c5f32f804ba632a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -40 lines) Patch
M content/renderer/input/input_event_filter_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/input/main_thread_event_queue.cc View 1 chunk +19 lines, -7 lines 0 comments Download
M content/renderer/input/main_thread_event_queue_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/input/render_widget_input_handler.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/events/WheelEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/WheelEvent.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/PlatformWheelEvent.h View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebInputEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp View 1 chunk +29 lines, -17 lines 0 comments Download
M third_party/WebKit/public/web/WebInputEvent.h View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years, 8 months ago (2016-04-22 14:01:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0da211979aa69008d06680383c5f32f804ba632a.

Powered by Google App Engine
This is Rietveld 408576698